issue_comments

Table actions

18 rows where "updated_at" is on date 2023-08-29 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

author_association 3

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1697818917 https://github.com/simonw/datasette/issues/2163#issuecomment-1697818917 https://api.github.com/repos/simonw/datasette/issues/2163 IC_kwDOBm6k_c5lMqkl simonw 9599 2023-08-29T16:56:20Z 2023-08-29T16:56:20Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Rename core_X to catalog_X in the internals 1872043170  
1691798722 https://github.com/simonw/datasette/pull/2154#issuecomment-1691798722 https://api.github.com/repos/simonw/datasette/issues/2154 IC_kwDOBm6k_c5k1szC codecov[bot] 22429695 2023-08-24T14:31:42Z 2023-08-29T16:15:12Z NONE

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% :tada:

Comparison is base (2e28258) 92.82% compared to head (3e49fd3) 92.85%. Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2154 +/- ## ========================================== + Coverage 92.82% 92.85% +0.03% ========================================== Files 40 40 Lines 5948 6008 +60 ========================================== + Hits 5521 5579 +58 - Misses 427 429 +2 ``` | [Files Changed](https://app.codecov.io/gh/simonw/datasette/pull/2154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage Δ | | |---|---|---| | [datasette/views/special.py](https://app.codecov.io/gh/simonw/datasette/pull/2154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3ZpZXdzL3NwZWNpYWwucHk=) | `94.06% <ø> (-0.85%)` | :arrow_down: | | [datasette/app.py](https://app.codecov.io/gh/simonw/datasette/pull/2154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL2FwcC5weQ==) | `94.37% <100.00%> (+0.07%)` | :arrow_up: | | [datasette/default\_permissions.py](https://app.codecov.io/gh/simonw/datasette/pull/2154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL2RlZmF1bHRfcGVybWlzc2lvbnMucHk=) | `97.48% <100.00%> (+0.57%)` | :arrow_up: | | [datasette/permissions.py](https://app.codecov.io/gh/simonw/datasette/pull/2154?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3Blcm1pc3Npb25zLnB5) | `100.00% <100.00%> (ø)` | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/simonw/datasette/pull/2154/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Cascade for restricted token view-table/view-database/view-instance operations 1865281760  
1697725150 https://github.com/simonw/datasette/pull/2154#issuecomment-1697725150 https://api.github.com/repos/simonw/datasette/issues/2154 IC_kwDOBm6k_c5lMTre simonw 9599 2023-08-29T15:54:12Z 2023-08-29T15:54:12Z OWNER

In that last commit I also upgraded Permission from a named tuple to a dataclass, and added a implies_can_view=True private (not documented) option to it.

Last step is to refactor the code to use that new property.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Cascade for restricted token view-table/view-database/view-instance operations 1865281760  
1697612168 https://github.com/simonw/datasette/pull/2154#issuecomment-1697612168 https://api.github.com/repos/simonw/datasette/issues/2154 IC_kwDOBm6k_c5lL4GI simonw 9599 2023-08-29T14:57:54Z 2023-08-29T14:57:54Z OWNER

The code to refactor is this: https://github.com/simonw/datasette/blob/d64a9896f743f87b673d58859a0ec16685594e79/datasette/default_permissions.py#L181-L280

I'm going to turn that into a more general restrictions_allow_action function.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Cascade for restricted token view-table/view-database/view-instance operations 1865281760  
1696710911 https://github.com/simonw/datasette/pull/2162#issuecomment-1696710911 https://api.github.com/repos/simonw/datasette/issues/2162 IC_kwDOBm6k_c5lIcD_ simonw 9599 2023-08-29T03:23:44Z 2023-08-29T03:23:44Z OWNER

I'm going to merge this so we can see how it feels.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add new `--internal internal.db` option, deprecate legacy `_internal` database 1870672704  
1696709110 https://github.com/simonw/datasette/pull/2162#issuecomment-1696709110 https://api.github.com/repos/simonw/datasette/issues/2162 IC_kwDOBm6k_c5lIbn2 simonw 9599 2023-08-29T03:20:40Z 2023-08-29T03:22:47Z OWNER

However, one important notes about those new core_ tables: If a --internal DB is passed in, that means those core_ tables will persist across multiple Datasette instances. This wasn't the case before, since _internal was always an in-memory database created from scratch.

I'm completely happy for the core_* tables (or datasette_* or some other name) to live in the persisted-to-disk internal.db database, even though they're effectively meant to be an in-memory cache.

I don't think it causes any harm, and it could even be quite useful to have them visible on disk - other applications could read the internal.db database while Datasette itself is running, should they have some weird reason to want to do that!

Having those tables stick around in internal.db after Datasette shuts down could be useful for other debugging activities as well.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add new `--internal internal.db` option, deprecate legacy `_internal` database 1870672704  
1696594855 https://github.com/simonw/datasette/pull/2162#issuecomment-1696594855 https://api.github.com/repos/simonw/datasette/issues/2162 IC_kwDOBm6k_c5lH_un codecov[bot] 22429695 2023-08-29T00:19:29Z 2023-08-29T03:22:21Z NONE

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.03% :warning:

Comparison is base (2e28258) 92.82% compared to head (73489ca) 92.79%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2162 +/- ## ========================================== - Coverage 92.82% 92.79% -0.03% ========================================== Files 40 40 Lines 5948 5953 +5 ========================================== + Hits 5521 5524 +3 - Misses 427 429 +2 ``` | [Files Changed](https://app.codecov.io/gh/simonw/datasette/pull/2162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage Δ | | |---|---|---| | [datasette/default\_permissions.py](https://app.codecov.io/gh/simonw/datasette/pull/2162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL2RlZmF1bHRfcGVybWlzc2lvbnMucHk=) | `96.87% <ø> (-0.04%)` | :arrow_down: | | [datasette/app.py](https://app.codecov.io/gh/simonw/datasette/pull/2162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL2FwcC5weQ==) | `94.32% <100.00%> (+0.03%)` | :arrow_up: | | [datasette/cli.py](https://app.codecov.io/gh/simonw/datasette/pull/2162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL2NsaS5weQ==) | `82.53% <100.00%> (-0.06%)` | :arrow_down: | | [datasette/database.py](https://app.codecov.io/gh/simonw/datasette/pull/2162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL2RhdGFiYXNlLnB5) | `94.72% <100.00%> (+0.04%)` | :arrow_up: | | [datasette/utils/internal\_db.py](https://app.codecov.io/gh/simonw/datasette/pull/2162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3V0aWxzL2ludGVybmFsX2RiLnB5) | `100.00% <100.00%> (ø)` | | | [datasette/views/database.py](https://app.codecov.io/gh/simonw/datasette/pull/2162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3ZpZXdzL2RhdGFiYXNlLnB5) | `95.45% <100.00%> (ø)` | | | [datasette/views/special.py](https://app.codecov.io/gh/simonw/datasette/pull/2162?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-ZGF0YXNldHRlL3ZpZXdzL3NwZWNpYWwucHk=) | `94.06% <100.00%> (-0.85%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add new `--internal internal.db` option, deprecate legacy `_internal` database 1870672704  
1696707458 https://github.com/simonw/datasette/pull/2162#issuecomment-1696707458 https://api.github.com/repos/simonw/datasette/issues/2162 IC_kwDOBm6k_c5lIbOC simonw 9599 2023-08-29T03:17:54Z 2023-08-29T03:17:54Z OWNER

Documentation preview: https://datasette--2162.org.readthedocs.build/en/2162/internals.html#datasette-s-internal-database

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add new `--internal internal.db` option, deprecate legacy `_internal` database 1870672704  
1696644066 https://github.com/simonw/datasette/pull/2154#issuecomment-1696644066 https://api.github.com/repos/simonw/datasette/issues/2154 IC_kwDOBm6k_c5lILvi simonw 9599 2023-08-29T01:37:47Z 2023-08-29T03:00:25Z OWNER

Code for this might be cleaner with a Restrictions() class that takes a "_r" dictionary to the constructor and can then answer questions like .any_resource_has_permission("view-table") - where it can resolve aliases etc as well.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Cascade for restricted token view-table/view-database/view-instance operations 1865281760  
1696642671 https://github.com/simonw/datasette/pull/2154#issuecomment-1696642671 https://api.github.com/repos/simonw/datasette/issues/2154 IC_kwDOBm6k_c5lILZv simonw 9599 2023-08-29T01:35:37Z 2023-08-29T01:35:37Z OWNER

Reminder that I also need to confirm that insert-row works if you have it at the instance level, the database level or the resource level in _r.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Cascade for restricted token view-table/view-database/view-instance operations 1865281760  
1696618784 https://github.com/simonw/datasette/pull/2154#issuecomment-1696618784 https://api.github.com/repos/simonw/datasette/issues/2154 IC_kwDOBm6k_c5lIFkg simonw 9599 2023-08-29T00:58:34Z 2023-08-29T00:58:34Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Cascade for restricted token view-table/view-database/view-instance operations 1865281760  
1695754277 https://github.com/simonw/datasette/pull/2160#issuecomment-1695754277 https://api.github.com/repos/simonw/datasette/issues/2160 IC_kwDOBm6k_c5lEygl codecov[bot] 22429695 2023-08-28T14:00:17Z 2023-08-29T00:32:52Z NONE

Codecov Report

Patch and project coverage have no change.

Comparison is base (2e28258) 92.82% compared to head (c81b024) 92.82%.

:exclamation: Current head c81b024 differs from pull request most recent head 3529c9c. Consider uploading reports for the commit 3529c9c to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2160 +/- ## ======================================= Coverage 92.82% 92.82% ======================================= Files 40 40 Lines 5948 5948 ======================================= Hits 5521 5521 Misses 427 427 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Bump sphinx, furo, blacken-docs dependencies 1869807874  
1696595326 https://github.com/simonw/datasette/pull/2160#issuecomment-1696595326 https://api.github.com/repos/simonw/datasette/issues/2160 IC_kwDOBm6k_c5lH_1- simonw 9599 2023-08-29T00:20:08Z 2023-08-29T00:20:08Z OWNER

Cog failed!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Bump sphinx, furo, blacken-docs dependencies 1869807874  
1696592763 https://github.com/simonw/datasette/pull/2160#issuecomment-1696592763 https://api.github.com/repos/simonw/datasette/issues/2160 IC_kwDOBm6k_c5lH_N7 simonw 9599 2023-08-29T00:16:38Z 2023-08-29T00:16:38Z OWNER

Since this bumps Sphinx I'm manually reviewing the ReadTheDocs preview a bit, looks good to me: https://datasette--2160.org.readthedocs.build/en/2160/

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Bump sphinx, furo, blacken-docs dependencies 1869807874  
1696591957 https://github.com/simonw/datasette/pull/2148#issuecomment-1696591957 https://api.github.com/repos/simonw/datasette/issues/2148 IC_kwDOBm6k_c5lH_BV dependabot[bot] 49699333 2023-08-29T00:15:29Z 2023-08-29T00:15:29Z CONTRIBUTOR

This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Bump sphinx, furo, blacken-docs dependencies 1859415334  
1696591943 https://github.com/simonw/datasette/pull/2148#issuecomment-1696591943 https://api.github.com/repos/simonw/datasette/issues/2148 IC_kwDOBm6k_c5lH_BH simonw 9599 2023-08-29T00:15:27Z 2023-08-29T00:15:27Z OWNER

Now solving this here: - #2160 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Bump sphinx, furo, blacken-docs dependencies 1859415334  
1696586767 https://github.com/simonw/datasette/pull/2160#issuecomment-1696586767 https://api.github.com/repos/simonw/datasette/issues/2160 IC_kwDOBm6k_c5lH9wP simonw 9599 2023-08-29T00:08:26Z 2023-08-29T00:08:35Z OWNER

https://github.com/simonw/datasette/issues/2148#issuecomment-1689177556

Simplest possible solution is to only run the pip install .[docs] bit under Python 3.9+, ditto for the docs tests. I think I'll try that.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Bump sphinx, furo, blacken-docs dependencies 1869807874  
1696586213 https://github.com/simonw/datasette/pull/2160#issuecomment-1696586213 https://api.github.com/repos/simonw/datasette/issues/2160 IC_kwDOBm6k_c5lH9nl simonw 9599 2023-08-29T00:07:46Z 2023-08-29T00:07:46Z OWNER

I figured out why this was failing in: - https://github.com/simonw/datasette/pull/2148

It's because Sphinx dropped support for Python 3.8.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Bump sphinx, furo, blacken-docs dependencies 1869807874  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);