issues

Table actions

53 rows where milestone = 6026070 and repo = 107914493 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: user, comments, author_association, created_at (date), updated_at (date), closed_at (date)

type 2

state 1

repo 1

  • datasette · 53 ✖
id node_id number title user state locked assignee milestone comments created_at updated_at ▲ closed_at author_association pull_request body repo type active_lock_reason performed_via_github_app reactions draft state_reason
723803777 MDU6SXNzdWU3MjM4MDM3Nzc= 1028 --load-extension=spatialite shortcut simonw 9599 closed 0   0.51 6026070 1 2020-10-17T17:02:08Z 2022-01-20T21:29:41Z 2020-10-19T22:37:55Z OWNER  

I added this to sqlite-utils in https://github.com/simonw/sqlite-utils/issues/136 and I really like it: pass a special value of spatialite and Datasette should attempt to load it from known likely installation locations.

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1028/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
637395097 MDU6SXNzdWU2MzczOTUwOTc= 838 Incorrect URLs when served behind a proxy with base_url set tsibley 79913 closed 0   0.51 6026070 14 2020-06-11T23:58:55Z 2021-11-20T19:35:48Z 2021-11-20T19:35:48Z NONE  

I'm running datasette serve --config base_url:/foo/ …, proxying to it with this Apache config:

    ProxyPass /foo/ http://localhost:8001/ 
    ProxyPassReverse /foo/ http://localhost:8001/

and then accessing it via https://example.com/foo/.

Although many of the URLs in the pages are correct (presumably because they either use absolute paths which include base_url or relative paths), the faceting and pagination links still use fully-qualified URLs pointing at http://localhost:8001.

I looked into this a little in the source code, and it seems to be an issue anywhere request.url or request.path is used, as these contain the values for the request between the frontend (Apache) and backend (Datasette) server. Those properties are primarily used via the path_with_… family of utility functions and the Datasette.absolute_url method.

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/838/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
725184645 MDU6SXNzdWU3MjUxODQ2NDU= 1034 Better way of representing binary data in .csv output simonw 9599 closed 0   0.51 6026070 19 2020-10-20T04:28:58Z 2021-06-17T18:13:21Z 2020-10-29T22:47:46Z OWNER  

I just noticed this: https://latest.datasette.io/fixtures/binary_data.csv

csv rowid,data 1,b'\x15\x1c\x02\xc7\xad\x05\xfe' 2,b'\x15\x1c\x03\xc7\xad\x05\xfe' There's no good way to represent binary data in a CSV file, but this seems like one of the more-bad options.

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1034/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
732685643 MDU6SXNzdWU3MzI2ODU2NDM= 1063 .csv should link to .blob downloads simonw 9599 closed 0   0.51 6026070 3 2020-10-29T21:45:58Z 2021-06-17T18:12:30Z 2020-10-29T22:47:45Z OWNER  
  • [x] Update .csv output to link to these things (and get that xfail test to pass)
  • ~~Add a .csv?_blob_base64=1 argument that causes them to be output in base64 in the CSV~~

Moving the CSV work to a separate ticket. Originally posted by @simonw in https://github.com/simonw/datasette/pull/1061#issuecomment-719042601

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1063/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
725996507 MDU6SXNzdWU3MjU5OTY1MDc= 1036 Make it possible to download BLOB data from the Datasette UI simonw 9599 closed 0   0.51 6026070 16 2020-10-20T22:47:56Z 2021-01-18T17:45:00Z 2020-10-25T00:14:52Z OWNER  

Currently you can only extract binary BLOB data as base64-encoded JSON, which is not user friendly at all. It should always be possible for end-users to get the binary data out.

I'm worried about XSS vulnerabilities here, but hopefully sending Content-Type: application/octet-stream helps there? Need to research that.

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1036/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
717699884 MDU6SXNzdWU3MTc2OTk4ODQ= 998 Wide tables should scroll horizontally within the page simonw 9599 closed 0   0.51 6026070 8 2020-10-08T22:13:27Z 2020-12-11T09:25:09Z 2020-10-22T01:12:26Z OWNER  

Wrap the main table in <div style="overflow-x: auto">

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/998/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
722673818 MDU6SXNzdWU3MjI2NzM4MTg= 1023 Fix issues relating to base_url simonw 9599 closed 0   0.51 6026070 3 2020-10-15T21:02:06Z 2020-11-24T19:51:44Z 2020-10-31T20:51:01Z OWNER  

Lots of base_url bugs that I'd like to solve at once.

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1023/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
644582921 MDU6SXNzdWU2NDQ1ODI5MjE= 865 base_url doesn't seem to work when adding criteria and clicking "apply" tballison 6739646 closed 0   0.51 6026070 11 2020-06-24T12:39:57Z 2020-11-12T23:49:24Z 2020-10-20T05:22:59Z NONE  

Over on Apache Tika, we're using datasette to allow users to make sense of the metadata for our file regression testing corpus.

This could be user error in how I've set up the reverse proxy!

I started datasette like so: docker run -d -p 8001:8001 -vpwd:/mnt datasetteproject/datasette datasette -p 8001 -h 0.0.0.0 /mnt/corpora-metadata.db --config sql_time_limit_ms:60000 --config base_url:/datasette/

I then reverse proxied like so:

ProxyPreserveHost On ProxyPass /datasette http://x.y.z.q:xxxx ProxyPassReverse /datasette http://x.y.z.q:xxx

Regular sql works perfectly: https://corpora.tika.apache.org/datasette/corpora-metadata?sql=select+mime_string%2C+count%281%29+as+cnt%0D%0Afrom+profiles+p%0D%0Ajoin+mimes+m+on+p.mime_id%3Dm.mime_id%0D%0Agroup+by+mime_string%0D%0Aorder+by+cnt+desc

However, adding criteria and clicking 'Apply' https://corpora.tika.apache.org/datasette/corpora-metadata/tika_1_24_1_mimes?_sort=file&mime__exact=text%2Fplain

bounces back to: https://corpora.tika.apache.org/corpora-metadata/tika_1_24_1_mimes?_sort=file&file__contains=bug&mime__exact=text%2Fplain

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/865/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
733805089 MDU6SXNzdWU3MzM4MDUwODk= 1076 Release notes for 0.51 simonw 9599 closed 0   0.51 6026070 0 2020-10-31T20:51:21Z 2020-10-31T22:27:00Z 2020-10-31T22:27:00Z OWNER   datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1076/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
728895233 MDU6SXNzdWU3Mjg4OTUyMzM= 1047 A new section in the docs about how Datasette handles BLOB columns simonw 9599 closed 0   0.51 6026070 1 2020-10-24T23:01:02Z 2020-10-31T22:11:25Z 2020-10-31T21:38:05Z OWNER  

Split from #1040, refs #1036.

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1047/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
722758132 MDU6SXNzdWU3MjI3NTgxMzI= 1027 Add documentation on serving Datasette behind a proxy using base_url simonw 9599 closed 0   0.51 6026070 5 2020-10-15T23:46:29Z 2020-10-31T21:14:05Z 2020-10-31T21:14:05Z OWNER  

This can go on this page: https://docs.datasette.io/en/stable/deploying.html

Refs #1023, #865

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1027/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
727627923 MDU6SXNzdWU3Mjc2Mjc5MjM= 1041 extra_js_urls and extra_css_urls should respect base_url setting simonw 9599 closed 0   0.51 6026070 4 2020-10-22T18:34:33Z 2020-10-31T20:49:28Z 2020-10-31T20:48:58Z OWNER   datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1041/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
733796942 MDU6SXNzdWU3MzM3OTY5NDI= 1075 PrefixedUrlString mechanism broke everything simonw 9599 closed 0   0.51 6026070 6 2020-10-31T19:58:05Z 2020-10-31T20:48:51Z 2020-10-31T20:48:51Z OWNER  

Added in 7a67bc7a569509d65b3a8661e0ad2c65f0b09166 refs #1026. Lots of tests are failing now.

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1075/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
733499930 MDU6SXNzdWU3MzM0OTk5MzA= 1072 load_template hook doesn't work for include/extends simonw 9599 closed 0   0.51 6026070 20 2020-10-30T20:33:44Z 2020-10-31T20:48:18Z 2020-10-30T22:50:57Z OWNER  

Includes like this one always go to disk, without hitting the load_template plugin hook: ```html+jinja

<footer class="ft">{% block footer %}{% include "_footer.html" %}{% endblock %}</footer>

```

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1072/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
733768037 MDU6SXNzdWU3MzM3NjgwMzc= 1074 latest.datasette.io should include plugins from fixtures simonw 9599 closed 0   0.51 6026070 3 2020-10-31T17:23:23Z 2020-10-31T19:47:47Z 2020-10-31T19:47:47Z OWNER  

It bothers me that these aren't visible in any public demos. Maybe latest.datasette.io should include the my_plugins.py and my_plugins2.py plugins? Originally posted by @simonw in https://github.com/simonw/datasette/issues/1067#issuecomment-719961701

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1074/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
722738988 MDU6SXNzdWU3MjI3Mzg5ODg= 1026 How should datasette.client interact with base_url simonw 9599 closed 0   0.51 6026070 5 2020-10-15T23:07:11Z 2020-10-31T19:29:52Z 2020-10-31T19:29:51Z OWNER  

Refs #1023. If Datasette is running with a base_url setting and a plugin calls e.g. datasette.client.get("/-/plugins.json") what should happen?

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1026/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
725743755 MDU6SXNzdWU3MjU3NDM3NTU= 1035 datasette.urls.table(..., format="json") argument simonw 9599 closed 0   0.51 6026070 3 2020-10-20T16:09:34Z 2020-10-31T18:16:43Z 2020-10-31T18:16:43Z OWNER  

That datasette.urls.table("db", "table") + ".json" example is bad because if the table name contains a . it should be ?_format=json instead.

Maybe .table() should have a format="json" option that knows how to do this.

Originally posted by @simonw in https://github.com/simonw/datasette/issues/1026#issuecomment-712962517

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1035/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
732905360 MDU6SXNzdWU3MzI5MDUzNjA= 1067 Table actions menu on view pages, not on query pages simonw 9599 closed 0   0.51 6026070 6 2020-10-30T05:56:39Z 2020-10-31T17:51:31Z 2020-10-31T17:40:14Z OWNER  

Follow-on from #1066.

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1067/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
733390884 MDU6SXNzdWU3MzMzOTA4ODQ= 1070 load_template() example in documentation showing loading from a database simonw 9599 closed 0   0.51 6026070 1 2020-10-30T17:45:03Z 2020-10-31T16:22:51Z 2020-10-31T16:22:45Z OWNER  

I should include an example in the documentation that shows loading templates from a database table. Originally posted by @simonw in https://github.com/simonw/datasette/pull/1069#issuecomment-719664530

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1070/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
733560417 MDU6SXNzdWU3MzM1NjA0MTc= 1073 Remove load_template plugin hook simonw 9599 closed 0   0.51 6026070 1 2020-10-30T22:51:52Z 2020-10-31T16:22:00Z 2020-10-31T16:22:00Z OWNER  

I couldn't get it working correctly with async (necessary for include/extend to function), and on deeper investigation it appears that I can build something equivalent to what I wanted using the existing prepare_jinja2_environment hook.

I'm going to remove the load_template plugin hook and see if it's possible to build the edit templates extension against prepare_jinja2_environment instead. Originally posted by @simonw in https://github.com/simonw/datasette/issues/1072#issuecomment-719833744

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1073/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
733485423 MDU6SXNzdWU3MzM0ODU0MjM= 1071 Messages should be displayed full width simonw 9599 closed 0   0.51 6026070 1 2020-10-30T20:11:35Z 2020-10-30T20:20:02Z 2020-10-30T20:13:05Z OWNER  

In the pattern portfolio:

But they're currently showing like this:

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1071/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
727802081 MDU6SXNzdWU3Mjc4MDIwODE= 1042 Plugin hook for loading templates simonw 9599 closed 0   0.51 6026070 14 2020-10-23T00:18:39Z 2020-10-30T17:47:21Z 2020-10-30T17:47:20Z OWNER  

This can work with the Jinja template loaders. It would unlock things like storing templates in SQLite.

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1042/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
733303548 MDExOlB1bGxSZXF1ZXN0NTEzMTA2MDI2 1069 load_template() plugin hook simonw 9599 closed 0   0.51 6026070 6 2020-10-30T15:59:45Z 2020-10-30T17:47:20Z 2020-10-30T17:47:19Z OWNER simonw/datasette/pulls/1069

Refs #1042

 datasette 107914493 pull     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1069/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 0  
732939921 MDU6SXNzdWU3MzI5Mzk5MjE= 1068 Default menu links should check a real permission simonw 9599 closed 0   0.51 6026070 5 2020-10-30T07:08:34Z 2020-10-30T15:44:13Z 2020-10-30T15:42:11Z OWNER  

https://github.com/simonw/datasette/blob/18a64fbb29271ce607937110bbdb55488c43f4e0/datasette/default_menu_links.py#L4-L6

This should check a named permission so that it can be customized by permission plugins.

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1068/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
573755726 MDU6SXNzdWU1NzM3NTU3MjY= 690 Mechanism for plugins to add action menu items for various things simonw 9599 closed 0   0.51 6026070 11 2020-03-02T06:48:36Z 2020-10-30T05:20:43Z 2020-10-30T05:20:42Z OWNER  

Now that we have support for plugins that can write I'm seeing all sorts of places where a plugin might need to add UI to the table page.

Some examples:

  • datasette-configure-fts needs to add a "configure search for this table" link
  • a plugin that lets you render or delete tables needs to add a link or button somewhere
  • existing plugins like datasette-vega and datasette-cluster-map already do this with JavaScript

The challenge here is that multiple plugins may want to do this, so simply overriding templates and populating names blocks doesn't entirely work as templates may override each other.

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/690/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
732859030 MDU6SXNzdWU3MzI4NTkwMzA= 1066 Table actions menu plus plugin hook simonw 9599 closed 0   0.51 6026070 3 2020-10-30T03:46:54Z 2020-10-30T05:18:36Z 2020-10-30T05:16:50Z OWNER  

For the table actions: attaching it to a cog icon next to the table name could make sense.

This is the column action icon at twice the size, color #666. Originally posted by @simonw in https://github.com/simonw/datasette/issues/690#issuecomment-709497595

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1066/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
732856937 MDExOlB1bGxSZXF1ZXN0NTEyNzM2NzA1 1065 Nav menu plus menu_links() hook simonw 9599 closed 0   0.51 6026070 1 2020-10-30T03:40:18Z 2020-10-30T03:45:17Z 2020-10-30T03:45:16Z OWNER simonw/datasette/pulls/1065

Closes #1064, refs #690.

 datasette 107914493 pull     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1065/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 0  
732798913 MDU6SXNzdWU3MzI3OTg5MTM= 1064 Navigation menu plus plugin hook simonw 9599 closed 0   0.51 6026070 10 2020-10-30T00:49:36Z 2020-10-30T03:45:16Z 2020-10-30T03:45:16Z OWNER   datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1064/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
732634375 MDExOlB1bGxSZXF1ZXN0NTEyNTQ1MzY0 1061 .blob output renderer simonw 9599 closed 0   0.51 6026070 4 2020-10-29T20:25:08Z 2020-10-29T22:01:40Z 2020-10-29T22:01:39Z OWNER simonw/datasette/pulls/1061
  • [x] Remove the /-/...blob/... route I added in #1040 in place of the new .blob renderer URLs
  • [x] Link to new .blob download links on the arbitrary query page (using _blob_hash=...) - plus tests for this

Closes #1050, Closes #1051

 datasette 107914493 pull     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1061/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 0  
729057388 MDU6SXNzdWU3MjkwNTczODg= 1050 Switch to .blob render extension for BLOB downloads simonw 9599 closed 0   0.51 6026070 10 2020-10-25T16:26:21Z 2020-10-29T22:01:39Z 2020-10-29T22:01:39Z OWNER  

This may require a complete rethink of the /db/table/-/blob/row/column.blob mechanism I just built for #1036.

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1050/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
729604838 MDU6SXNzdWU3Mjk2MDQ4Mzg= 1053 Document recommendations for plugin authors to design URLs simonw 9599 closed 0   0.51 6026070 1 2020-10-26T14:19:21Z 2020-10-29T19:37:58Z 2020-10-29T19:35:40Z OWNER  

See thread: https://twitter.com/kanedr/status/1320653434895347713

The process and API for making a plugin is great btw. One question I had was the best format for URLs. I've created an url like /<database>/<table>/reconcile as a json endpoint, but that could conflict with the row-level URLs. Is there a recommended pattern to use?

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1053/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
730199464 MDU6SXNzdWU3MzAxOTk0NjQ= 1054 Switch from versioneer to concrete version in setup.py simonw 9599 closed 0   0.51 6026070 2 2020-10-27T07:38:08Z 2020-10-29T03:38:18Z 2020-10-29T03:38:17Z OWNER  

The new PyPI resolver keeps on showing me warnings like this one when I install Datasette directly from GitHub using pip install https://github.com/simonw/datasette/archive/main.zip: ``` Successfully built datasette Installing collected packages: datasette Attempting uninstall: datasette Found existing installation: datasette 0.50.2 Uninstalling datasette-0.50.2: Successfully uninstalled datasette-0.50.2 ERROR: After October 2020 you may experience errors when installing or updating packages. This is because pip will change the way that it resolves dependency conflicts.

We recommend you use --use-feature=2020-resolver to test your packages with the new resolver before it becomes the default.

datasette-upload-csvs 0.5 requires datasette>=0.47, but you'll have datasette 0+unknown which is incompatible. datasette-publish-vercel 0.8 requires datasette>=0.44, but you'll have datasette 0+unknown which is incompatible. datasette-psutil 0.2 requires datasette>=0.44, but you'll have datasette 0+unknown which is incompatible. datasette-leaflet-geojson 0.6 requires datasette>=0.48, but you'll have datasette 0+unknown which is incompatible. datasette-edit-schema 0.3 requires datasette>=0.44, but you'll have datasette 0+unknown which is incompatible. datasette-cluster-map 0.13 requires datasette>=0.48, but you'll have datasette 0+unknown which is incompatible. Successfully installed datasette-0+unknown `` This is because we use versioneer. I'm going to drop that in favour of embedding the version directly insetup.py, like I do in other projects such assqlite-utils`.

I'll use a .dev suffix in the development version, as suggested by https://www.python.org/dev/peps/pep-0440/#developmental-releases

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1054/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
731827081 MDExOlB1bGxSZXF1ZXN0NTExODY4MTUz 1060 New explicit versioning mechanism simonw 9599 closed 0   0.51 6026070 1 2020-10-28T22:14:55Z 2020-10-29T03:38:17Z 2020-10-29T03:38:16Z OWNER simonw/datasette/pulls/1060
  • Remove all references to versioneer
  • Re-implement versioning to use a static string baked into the repo
  • Ensure that string is output by datasette --version and /-/versions

Refs #1054

 datasette 107914493 pull     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1060/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 0  
730802994 MDU6SXNzdWU3MzA4MDI5OTQ= 1058 Database download should implement cascading permissions simonw 9599 closed 0   0.51 6026070 1 2020-10-27T20:43:27Z 2020-10-28T03:15:47Z 2020-10-28T03:15:47Z OWNER   datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1058/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
730797787 MDU6SXNzdWU3MzA3OTc3ODc= 1057 --cors should enable /fixtures.db CORS access simonw 9599 closed 0   0.51 6026070 1 2020-10-27T20:38:34Z 2020-10-27T20:52:05Z 2020-10-27T20:51:09Z OWNER  

So Datasette can work with SQL.js as seen in https://observablehq.com/@mbostock/sqlite

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1057/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
726094754 MDU6SXNzdWU3MjYwOTQ3NTQ= 1037 Add horizontal scrollbar to tables simonw 9599 closed 0   0.51 6026070 3 2020-10-21T03:13:34Z 2020-10-27T20:52:04Z 2020-10-21T03:16:36Z OWNER  

Currently you have to scroll the entire page sideways if a table is wide. Make the table overflow-x: auto instead.

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1037/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
729183332 MDU6SXNzdWU3MjkxODMzMzI= 1052 Column action menu overlapped by Leaflet maps simonw 9599 closed 0   0.51 6026070 1 2020-10-26T02:17:29Z 2020-10-27T20:52:04Z 2020-10-26T02:19:36Z OWNER  

Using datasette-leaflet-geojson:

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1052/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
730752399 MDExOlB1bGxSZXF1ZXN0NTExMDA1NTQy 1056 Radical new colour scheme and base styles, courtesy of @natbat simonw 9599 closed 0   0.51 6026070 1 2020-10-27T19:31:49Z 2020-10-27T19:39:57Z 2020-10-27T19:39:56Z OWNER simonw/datasette/pulls/1056
datasette 107914493 pull     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1056/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 0  
728895193 MDU6SXNzdWU3Mjg4OTUxOTM= 1046 Link to blob downloads in the right places simonw 9599 closed 0   0.51 6026070 2 2020-10-24T23:00:41Z 2020-10-25T00:13:21Z 2020-10-25T00:13:21Z OWNER  

Split from #1040, refs #1036.

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1046/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
726910999 MDExOlB1bGxSZXF1ZXN0NTA3OTAzMzky 1040 /db/table/-/blob/pk/column.blob download URL simonw 9599 closed 0   0.51 6026070 3 2020-10-21T22:39:15Z 2020-10-24T23:09:20Z 2020-10-24T23:09:19Z OWNER simonw/datasette/pulls/1040

Refs #1036. Still needs:

  • [x] Comprehensive tests across all of the code branches, plus permissions
  • [x] A bit more refactoring to share logic cleanly with RowView
  • ~~A configuration option to disable this feature (probably)~~
 datasette 107914493 pull     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1040/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 0  
725099777 MDU6SXNzdWU3MjUwOTk3Nzc= 1033 datasette.urls.static_plugins(...) method simonw 9599 closed 0   0.51 6026070 5 2020-10-20T01:16:32Z 2020-10-24T22:58:33Z 2020-10-24T20:03:52Z OWNER  

Follow-on from #904. For constructing URLs like this:

/-/static-plugins/NAME_OF_PLUGIN_PACKAGE/yourfile.js

Should be documented on https://docs.datasette.io/en/latest/writing_plugins.html#static-assets and https://docs.datasette.io/en/latest/internals.html#datasette-urls

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1033/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
497162288 MDU6SXNzdWU0OTcxNjIyODg= 575 Plugin documentation should cover how to bundle static/templates in setup.py simonw 9599 closed 0   0.51 6026070 1 2019-09-23T15:15:18Z 2020-10-24T20:06:17Z 2020-10-24T20:03:53Z OWNER   datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/575/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
728600048 MDU6SXNzdWU3Mjg2MDAwNDg= 1045 Document that datasette.render_template(template, ...) also accepts a list of templates simonw 9599 closed 0   0.51 6026070 1 2020-10-23T23:37:12Z 2020-10-24T00:22:10Z 2020-10-24T00:22:09Z OWNER  

https://docs.datasette.io/en/stable/internals.html#await-render-template-template-context-none-request-none

await .render_template(template, context=None, request=None)

This currently only accepts a single template. If it accepted a list of templates (where the first available template gets rendered) it could be more widely used by Datasette internally.

Spotted this while researching #1042.

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1045/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
726687572 MDU6SXNzdWU3MjY2ODc1NzI= 1039 Add an animation to the column actions menu simonw 9599 closed 0   0.51 6026070 1 2020-10-21T16:56:28Z 2020-10-23T19:44:07Z 2020-10-21T17:02:32Z OWNER  

Inspired by the animation on some of GitHub's dropdown menus:

https://github.com/primer/css/blob/da8ee54248e6d76c15c18e53684a15a6516b5b7f/src/utilities/animations.scss#L114-L131

```css / Fade in an element and scale it fast / .anim-scale-in { animation-name: scale-in; animation-duration: 0.15s; animation-timing-function: cubic-bezier(0.2, 0, 0.13, 1.5); }

@keyframes scale-in { 0% { opacity: 0; transform: scale(0.5); }

100% { opacity: 1; transform: scale(1); } } ```

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1039/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
718953669 MDU6SXNzdWU3MTg5NTM2Njk= 1016 Add a "delete" icon next to filters (in addition to "remove filter") simonw 9599 closed 0   0.51 6026070 3 2020-10-11T23:49:53Z 2020-10-23T19:44:06Z 2020-10-12T03:01:58Z OWNER  

The "remove filter" option in the select box is not very discoverable.

It would be good to have an additional remove icon, pointed to by the pink arrow, which removes a specific selected filter.

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1016/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
721050815 MDU6SXNzdWU3MjEwNTA4MTU= 1019 "Edit SQL" button on canned queries jsfenfen 639012 closed 0   0.51 6026070 7 2020-10-14T00:51:39Z 2020-10-23T19:44:06Z 2020-10-14T03:44:23Z CONTRIBUTOR  

Feature request: Would it be possible to add an "edit this query" button on canned queries? Clicking it would open the canned query as an editable sql query. I think the intent is to have named parameters to allow this, but sometimes you just gotta rewrite it?

datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1019/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
722674708 MDU6SXNzdWU3MjI2NzQ3MDg= 1024 Figure out how to run an environment that exercises the base_url proxy setting simonw 9599 closed 0   0.51 6026070 9 2020-10-15T21:03:39Z 2020-10-23T19:44:06Z 2020-10-15T22:34:04Z OWNER  

Refs #1023.

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1024/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
722724086 MDU6SXNzdWU3MjI3MjQwODY= 1025 Fix last remaining links to "/" that do not respect base_url simonw 9599 closed 0   0.51 6026070 7 2020-10-15T22:46:38Z 2020-10-23T19:44:06Z 2020-10-20T05:21:29Z OWNER  

Refs #1023 datasette % git grep '"/"' -- '*.html' datasette/templates/error.html: <a href="/">home</a> datasette/templates/patterns.html: <a href="/">home</a> / datasette/templates/query.html: <a href="/">home</a> /

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1025/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
663228985 MDU6SXNzdWU2NjMyMjg5ODU= 904 datasette.urls.table() / .instance() / .database() methods for constructing URLs, also exposed to templates simonw 9599 closed 0   0.51 6026070 11 2020-07-21T18:42:52Z 2020-10-23T19:44:05Z 2020-10-20T00:51:51Z OWNER  

I tried using this block of template in a plugin and got an error: html {% block nav %} <p class="crumbs"> <a href="{{ base_url }}">home</a> / <a href="{{ database_url(database) }}">{{ database }}</a> / <a href="{{ database_url(database) }}/{{ table|quote_plus }}">{{ table }}</a> </p> {{ super() }} {% endblock %} Error: 'database_url' is undefined

That's because database_url is only made available by the BaseView template here:

https://github.com/simonw/datasette/blob/d6e03b04302a0852e7133dc030eab50177c37be7/datasette/views/base.py#L110-L125

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/904/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
713209404 MDU6SXNzdWU3MTMyMDk0MDQ= 988 Mechanism for plugins to construct URLs that respect base_url simonw 9599 closed 0   0.51 6026070 2 2020-10-01T21:54:15Z 2020-10-23T19:44:05Z 2020-10-15T23:01:02Z OWNER  

Had a thought: this is likely to break in plugins too, such as datasette-edit-schema which constructs URLs for redirects e.g. here: https://github.com/simonw/datasette-edit-schema/blob/dbd0abee6dd3385b114cfe9671f7ead1c4855b60/datasette_edit_schema/init.py#L46-L48

Originally posted by @simonw in https://github.com/simonw/datasette/issues/865#issuecomment-702418045

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/988/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
718723543 MDU6SXNzdWU3MTg3MjM1NDM= 1014 Add Link: pagination HTTP headers simonw 9599 closed 0   0.51 6026070 6 2020-10-10T23:42:40Z 2020-10-23T19:44:05Z 2020-10-11T00:18:51Z OWNER  

Spun off from #782. These can go on all of the JSON endpoints that support pagination.

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/1014/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
634651079 MDU6SXNzdWU2MzQ2NTEwNzk= 814 Remove --debug option from datasette serve simonw 9599 closed 0   0.51 6026070 1 2020-06-08T14:10:14Z 2020-10-23T19:44:04Z 2020-10-10T23:39:43Z OWNER   datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/814/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed
661605489 MDU6SXNzdWU2NjE2MDU0ODk= 900 Some links don't honor base_url noteed 50220 closed 0   0.51 6026070 3 2020-07-20T09:40:50Z 2020-10-23T19:44:04Z 2020-10-15T22:57:55Z NONE  

Hi,

I've been playing with Datasette behind Nginx (awesome tool, thanks !). It seems some URLs are OK but some aren't. For instance in https://github.com/simonw/datasette/blob/master/datasette/templates/query.html#L61 it seems that url_csv includes a / prefix, resulting in the base_url not beeing honored.

Actually here, it seems that dropping the prefix / to make the link relative is enough (so it may not be strictly related to base_url).

Additional information:

datasette, version 0.45+0.gf1f581b.dirty

Relevant Nginx configuration (note that all the trailing slashes have some effect):

location /datasette/ { proxy_pass http://127.0.0.1:9001/; proxy_set_header Host $host; }

Relelvant Datasette configuration (slashes matter too):

--config base_url:/datasette/

 datasette 107914493 issue     
{
    "url": "https://api.github.com/repos/simonw/datasette/issues/900/reactions",
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   completed

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issues] (
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [number] INTEGER,
   [title] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [state] TEXT,
   [locked] INTEGER,
   [assignee] INTEGER REFERENCES [users]([id]),
   [milestone] INTEGER REFERENCES [milestones]([id]),
   [comments] INTEGER,
   [created_at] TEXT,
   [updated_at] TEXT,
   [closed_at] TEXT,
   [author_association] TEXT,
   [pull_request] TEXT,
   [body] TEXT,
   [repo] INTEGER REFERENCES [repos]([id]),
   [type] TEXT
, [active_lock_reason] TEXT, [performed_via_github_app] TEXT, [reactions] TEXT, [draft] INTEGER, [state_reason] TEXT);
CREATE INDEX [idx_issues_repo]
                ON [issues] ([repo]);
CREATE INDEX [idx_issues_milestone]
                ON [issues] ([milestone]);
CREATE INDEX [idx_issues_assignee]
                ON [issues] ([assignee]);
CREATE INDEX [idx_issues_user]
                ON [issues] ([user]);