issue_comments

Table actions

3 rows where author_association = "OWNER", issue = 913865304 and user = 9599 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

user 1

  • simonw · 3 ✖

issue 1

  • DRAFT: A new plugin hook for dynamic metadata · 3 ✖

author_association 1

  • OWNER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
869068554 https://github.com/simonw/datasette/pull/1368#issuecomment-869068554 https://api.github.com/repos/simonw/datasette/issues/1368 MDEyOklzc3VlQ29tbWVudDg2OTA2ODU1NA== simonw 9599 2021-06-26T22:23:57Z 2021-06-26T22:23:57Z OWNER

The only test failure is Black. I'm going to merge this and then reformat.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 DRAFT: A new plugin hook for dynamic metadata 913865304  
867102944 https://github.com/simonw/datasette/pull/1368#issuecomment-867102944 https://api.github.com/repos/simonw/datasette/issues/1368 MDEyOklzc3VlQ29tbWVudDg2NzEwMjk0NA== simonw 9599 2021-06-23T19:32:01Z 2021-06-23T19:32:01Z OWNER

Yes, let's move ahead with getting this into an alpha.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 DRAFT: A new plugin hook for dynamic metadata 913865304  
865160132 https://github.com/simonw/datasette/pull/1368#issuecomment-865160132 https://api.github.com/repos/simonw/datasette/issues/1368 MDEyOklzc3VlQ29tbWVudDg2NTE2MDEzMg== simonw 9599 2021-06-21T16:07:06Z 2021-06-21T16:08:48Z OWNER

A few tests failed - Black, the test that checks the docs mention the new hook - the most interesting failing test looks like this one: ``` updated_metadata["databases"]["fixtures"]["queries"]["magic_parameters"][ "allow" ] = (allow if "query" in permissions else deny)

      cascade_app_client.ds._metadata = updated_metadata

E AttributeError: can't set attribute ``` From https://github.com/simonw/datasette/blob/0a7621f96f8ad14da17e7172e8a7bce24ef78966/tests/test_permissions.py#L439-L467

This test is directly manipulating _metadata purely for the purposes of simulating different permissions - I think updating it to manipulate _local_metadata instead would fix that.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 DRAFT: A new plugin hook for dynamic metadata 913865304  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);