issue_comments

Note that if we went with a "update_metadata" hook, the hook signature would look something like this (it would return nothing):

update_metadata( datasette=self, metadata=metadata, key=key, database=database, table=table, fallback=fallback )

The Datasette function _metadata_recursive_update(self, orig, updated) would disappear into the plugins. Doing this, though, we'd lose the easy ability to make the local metadata.yaml immutable (since we'd no longer have the recursive update).

https://github.com/python/cpython/blob/2ab27c4af4ddf7528e1375e77c787c7fbb09b5e6/Lib/typing.py#L2173-L2195

In Python 3.6 or higher can do this:

python class Employee(NamedTuple): name: str id: int

I've hit this one too. I agree, fixing this in Datasette itself is better than fixing it in the tests across multiple other projects.

No point in showing the IDs twice if the blue label doesn't differ from the gray ID

Here's why: https://github.com/simonw/datasette/blob/03ec71193b9545536898a4bc7493274fec48bdd7/datasette/static/app.css#L455-L458

Here's an example of a test that uses it. It's necessary because sometimes fixtures that create temporary directories break in unexpected ways:

https://github.com/simonw/datasette/blob/0a7621f96f8ad14da17e7172e8a7bce24ef78966/tests/test_plugins.py#L658-L666

The hack in question is this fixture, which I've been using in an ad-hoc manner to work around errors while running the tests: https://github.com/simonw/datasette/blob/030deb4b25cda842ff7129ab7c18550c44dd8379/tests/conftest.py#L62-L75

I don't understand the underlying issue well enough to know how to get rid of it.

Looks like this is the way to do this: python Point = typing.NamedTuple( "Point", [('x', int), ('y', int)] )