issue_comments

Table actions

10 rows where "updated_at" is on date 2023-04-13 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

author_association 2

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1507264934 https://github.com/simonw/datasette/issues/2058#issuecomment-1507264934 https://api.github.com/repos/simonw/datasette/issues/2058 IC_kwDOBm6k_c5Z1wmm esagara 1138559 2023-04-13T16:35:21Z 2023-04-13T16:35:21Z NONE

I tried deploying the fix you submitted, but still getting the same errors. I can past the logs here if needed, but I really don't see anything new in them.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 500 "attempt to write a readonly database" error caused by "PRAGMA schema_version" 1663399821  
1506485287 https://github.com/simonw/datasette/pull/2056#issuecomment-1506485287 https://api.github.com/repos/simonw/datasette/issues/2056 IC_kwDOBm6k_c5ZyyQn cclauss 3709715 2023-04-13T07:29:38Z 2023-04-13T07:41:55Z NONE

Ruff (written in Rust, not Python) is a 23MB executable so the time to download and pip install it dwarfs its runtime.

Let's run ruff with and without GitHub Actions pip cache side-by-side to see the relative performance.

Once you approve the workflows below, ruff_with_cache should echo cache-hit = false but if you rerun that job hopefully it should echo cache-hit = true. That will be the execution time that we are interested to compare.

There are two great problems in computer science: ;-) 1. Naming things 2. Cache invalidation 3. Off-by-one errors

For 2., https://github.com/actions/setup-python#caching-packages-dependencies is vital reading. Only exactly pinned requirements can be cached. Currently in setup.py the only pinned dependencies are: 1. Sphinx==6.1.3 2. furo==2023.3.27 3. black==23.3.0 4. blacken-docs==1.13.0 # but unpinned elsewhere in setup.py

This means that there will be very few cache hits in the current actions. See the link below to print out cache hits: https://github.com/actions/setup-python/blob/main/docs/advanced-usage.md#cache-hit

PyPI uses Fastly's CDN to quickly serve content to end-users, allowing us to minimize our hosting infrastructure and obscure possible downtime. -- https://pypi.org/sponsors

I would be shocked if Fastly does not have beefy CDN nodes in the same datacenters where GitHub Actions run so GHA requests to download ruff probably never hit a PyPI server.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 GitHub Action to lint Python code with ruff 1661860507  
1506223848 https://github.com/simonw/sqlite-utils/issues/527#issuecomment-1506223848 https://api.github.com/repos/simonw/sqlite-utils/issues/527 IC_kwDOCGYnMM5Zxybo simonw 9599 2023-04-13T02:08:16Z 2023-04-13T02:08:16Z OWNER

I agree, this is a design flaw.

It's technically a breaking change. As such, I would need to bump to v4 to responsibly release this.

I'd rather bundle in a few more breaking changes before shipping that version.

One thing we could do here is add an extra argument to .convert() - something like this:

python table.convert(col, lambda x: x+1, skip_false=False)

This would trigger the new, improved behaviour without breaking existing code that depends on how it works at the moment.

Then in sqlite-utils 4 we can change the default of that option.

What do you think?

(I'm open to suggestions for better names for this parameter too)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 `Table.convert()` skips falsey values 1578790070  
1506203550 https://github.com/simonw/datasette/issues/2058#issuecomment-1506203550 https://api.github.com/repos/simonw/datasette/issues/2058 IC_kwDOBm6k_c5Zxtee cephillips 547438 2023-04-13T01:48:21Z 2023-04-13T01:48:21Z NONE

Really interesting how you are using ChatGPT in this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 500 "attempt to write a readonly database" error caused by "PRAGMA schema_version" 1663399821  
1506200813 https://github.com/simonw/sqlite-utils/pull/537#issuecomment-1506200813 https://api.github.com/repos/simonw/sqlite-utils/issues/537 IC_kwDOCGYnMM5Zxszt codecov[bot] 22429695 2023-04-13T01:45:22Z 2023-04-13T01:45:22Z NONE

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c0251cc) 96.25% compared to head (a75abeb) 96.25%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #537 +/- ## ======================================= Coverage 96.25% 96.25% ======================================= Files 6 6 Lines 2671 2673 +2 ======================================= + Hits 2571 2573 +2 Misses 100 100 ``` | [Impacted Files](https://codecov.io/gh/simonw/sqlite-utils/pull/537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison) | Coverage Δ | | |---|---|---| | [sqlite\_utils/db.py](https://codecov.io/gh/simonw/sqlite-utils/pull/537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison#diff-c3FsaXRlX3V0aWxzL2RiLnB5) | `97.33% <100.00%> (+<0.01%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Simon+Willison)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Support self-referencing FKs in `Table.create` 1665200812  
1506179555 https://github.com/simonw/datasette/pull/2056#issuecomment-1506179555 https://api.github.com/repos/simonw/datasette/issues/2056 IC_kwDOBm6k_c5Zxnnj simonw 9599 2023-04-13T01:21:05Z 2023-04-13T01:22:08Z OWNER

OK, I'm sold - this is a really neat improvement.

One thing to change in the PR: right now it runs pip install --user ruff on every commit, which hits PyPI to install the package.

I prefer to avoid hitting PyPI every time, so I like to use the GitHub Actions cache. My usual pattern for that looks like this:

https://github.com/simonw/datasette/blob/5890a20c374fb0812d88c9b0ef26a838bfa06c76/.github/workflows/test-pyodide.yml#L16-L20

Then a separate command that runs pip install ... will benefit from that cache.

Are you OK to make that change?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 GitHub Action to lint Python code with ruff 1661860507  
1506177857 https://github.com/simonw/datasette/pull/2056#issuecomment-1506177857 https://api.github.com/repos/simonw/datasette/issues/2056 IC_kwDOBm6k_c5ZxnNB simonw 9599 2023-04-13T01:18:18Z 2023-04-13T01:18:18Z OWNER

Cool - and now https://github.com/simonw/datasette/pull/2056/files is showing me those inline annotations:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 GitHub Action to lint Python code with ruff 1661860507  
1506177115 https://github.com/simonw/datasette/pull/2056#issuecomment-1506177115 https://api.github.com/repos/simonw/datasette/issues/2056 IC_kwDOBm6k_c5ZxnBb simonw 9599 2023-04-13T01:17:16Z 2023-04-13T01:17:16Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 GitHub Action to lint Python code with ruff 1661860507  
1506175208 https://github.com/simonw/datasette/pull/2056#issuecomment-1506175208 https://api.github.com/repos/simonw/datasette/issues/2056 IC_kwDOBm6k_c5Zxmjo simonw 9599 2023-04-13T01:14:13Z 2023-04-13T01:14:13Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 GitHub Action to lint Python code with ruff 1661860507  
1506174353 https://github.com/simonw/datasette/issues/2059#issuecomment-1506174353 https://api.github.com/repos/simonw/datasette/issues/2059 IC_kwDOBm6k_c5ZxmWR simonw 9599 2023-04-13T01:13:00Z 2023-04-13T01:13:00Z OWNER

Can you provide a URL to an example, and/or a screenshot of this? Is it a browser warning or is it a warning from Heroku itself?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "Deceptive site ahead" alert on Heroku deployment 1665053646  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);