issue_comments
10,495 rows sorted by updated_at descending
This data as json, CSV (advanced)
user 112
- simonw 2,891
- russss 39
- psychemedia 21
- abdusco 18
- chrismp 18
- aborruso 15
- carlmjohnson 12
- rixx 11
- terrycojones 9
- RhetTbull 9
- jacobian 8
- tomchristie 8
- bsilverm 8
- stonebig 7
- zeluspudding 7
- amjith 6
- wragge 6
- rgieseke 6
- clausjuhl 6
- dazzag24 5
- SteadBytes 5
- codecov[bot] 5
- jayvdb 4
- jaywgraves 4
- r4vi 4
- eyeseast 3
- janimo 3
- atomotic 3
- pkoppstein 3
- yschimke 3
- philroche 3
- macropin 3
- wsxiaoys 3
- xrotwang 3
- kevindkeogh 3
- garethr 2
- ftrain 2
- chrishas35 2
- ingenieroariel 2
- coleifer 2
- gavinband 2
- aviflax 2
- tholo 2
- cldellow 2
- gfrmin 2
- eads 2
- jsfenfen 2
- nathancahill 2
- betatim 2
- bsmithgall 2
- willingc 2
- raynae 2
- wulfmann 2
- zzeleznick 2
- tballison 2
- jsancho-gpl 2
- lagolucas 2
- chekos 2
- ad-si 2
- null92 2
- tunguyenatwork 2
- LVerneyPEReN 2
- gijs 1
- nkirsch 1
- tomdyson 1
- dmd 1
- Uninen 1
- carsonyl 1
- nryberg 1
- stefanocudini 1
- jefftriplett 1
- hpk42 1
- annapowellsmith 1
- tsibley 1
- Krazybug 1
- dvhthomas 1
- yozlet 1
- michaelmcandrew 1
- ipmb 1
- 0x1997 1
- davidszotten 1
- kevboh 1
- eaubin 1
- mhalle 1
- nickdirienzo 1
- heussd 1
- Gagravarr 1
- progpow 1
- ltrgoddard 1
- costrouc 1
- ccorcos 1
- fkuhn 1
- kwladyka 1
- phoenixjun 1
- JesperTreetop 1
- chris48s 1
- ChristopherWilks 1
- JBPressac 1
- Maltazar 1
- wuhland 1
- foscoj 1
- dvot197007 1
- rprimet 1
- metab0t 1
- coisnepe 1
- chmaynard 1
- LucasElArruda 1
- duarteocarmo 1
- dependabot-preview[bot] 1
- b0b5h4rp13 1
- jcmkk3 1
- thisismyfuckingusername 1
id | html_url | issue_url | node_id | user | created_at | updated_at ▲ | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
653962708 | https://github.com/dogsheep/github-to-sqlite/issues/41#issuecomment-653962708 | https://api.github.com/repos/dogsheep/github-to-sqlite/issues/41 | MDEyOklzc3VlQ29tbWVudDY1Mzk2MjcwOA== | simonw 9599 | 2020-07-06T00:43:10Z | 2020-07-06T00:43:10Z | MEMBER | I bet it's datasette-search-all. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Demo is failing to deploy 651159727 | |
653962669 | https://github.com/dogsheep/github-to-sqlite/issues/41#issuecomment-653962669 | https://api.github.com/repos/dogsheep/github-to-sqlite/issues/41 | MDEyOklzc3VlQ29tbWVudDY1Mzk2MjY2OQ== | simonw 9599 | 2020-07-06T00:42:57Z | 2020-07-06T00:42:57Z | MEMBER | https://github-to-sqlite.dogsheep.net/-/plugins
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Demo is failing to deploy 651159727 | |
653962530 | https://github.com/dogsheep/github-to-sqlite/issues/41#issuecomment-653962530 | https://api.github.com/repos/dogsheep/github-to-sqlite/issues/41 | MDEyOklzc3VlQ29tbWVudDY1Mzk2MjUzMA== | simonw 9599 | 2020-07-06T00:42:13Z | 2020-07-06T00:42:13Z | MEMBER | So it looks like it's the ASGI lifespan change I made in https://github.com/simonw/datasette/commit/16f592247a2a0e140ada487e9972645406dcae69 - It must be incompatible with one of the plugins. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Demo is failing to deploy 651159727 | |
653962418 | https://github.com/dogsheep/github-to-sqlite/issues/41#issuecomment-653962418 | https://api.github.com/repos/dogsheep/github-to-sqlite/issues/41 | MDEyOklzc3VlQ29tbWVudDY1Mzk2MjQxOA== | simonw 9599 | 2020-07-06T00:41:38Z | 2020-07-06T00:41:38Z | MEMBER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Demo is failing to deploy 651159727 | ||
653960989 | https://github.com/dogsheep/github-to-sqlite/issues/41#issuecomment-653960989 | https://api.github.com/repos/dogsheep/github-to-sqlite/issues/41 | MDEyOklzc3VlQ29tbWVudDY1Mzk2MDk4OQ== | simonw 9599 | 2020-07-06T00:32:34Z | 2020-07-06T00:32:34Z | MEMBER | Same error. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Demo is failing to deploy 651159727 | |
653947916 | https://github.com/dogsheep/github-to-sqlite/issues/41#issuecomment-653947916 | https://api.github.com/repos/dogsheep/github-to-sqlite/issues/41 | MDEyOklzc3VlQ29tbWVudDY1Mzk0NzkxNg== | simonw 9599 | 2020-07-05T22:40:47Z | 2020-07-05T22:40:47Z | MEMBER | Might be that it's not got enough RAM. I'll try deploying to a larger instance. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Demo is failing to deploy 651159727 | |
653314465 | https://github.com/simonw/datasette/pull/890#issuecomment-653314465 | https://api.github.com/repos/simonw/datasette/issues/890 | MDEyOklzc3VlQ29tbWVudDY1MzMxNDQ2NQ== | simonw 9599 | 2020-07-03T03:07:41Z | 2020-07-03T03:07:41Z | OWNER | This is an excellent fix. Thanks! Not sure why codecov is complaining. I'm going to merge it as-is. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Load only python files from plugins-dir. 650305298 | |
653309545 | https://github.com/simonw/datasette/pull/890#issuecomment-653309545 | https://api.github.com/repos/simonw/datasette/issues/890 | MDEyOklzc3VlQ29tbWVudDY1MzMwOTU0NQ== | codecov[bot] 22429695 | 2020-07-03T02:52:25Z | 2020-07-03T03:03:00Z | NONE | Codecov Report
```diff @@ Coverage Diff @@ master #890 +/-==========================================
- Coverage 83.42% 83.40% -0.02% | Impacted Files | Coverage Δ | |
|---|---|---|
| datasette/app.py | Continue to review full report at Codecov.
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Load only python files from plugins-dir. 650305298 | |
643711117 | https://github.com/simonw/datasette/pull/848#issuecomment-643711117 | https://api.github.com/repos/simonw/datasette/issues/848 | MDEyOklzc3VlQ29tbWVudDY0MzcxMTExNw== | codecov[bot] 22429695 | 2020-06-14T03:05:55Z | 2020-07-03T02:44:09Z | NONE | Codecov Report
```diff @@ Coverage Diff @@ master #848 +/-==========================================
- Coverage 83.42% 82.82% -0.61% | Impacted Files | Coverage Δ | |
|---|---|---|
| datasette/cli.py | Continue to review full report at Codecov.
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Reload support for config_dir mode. 638270441 | |
653002499 | https://github.com/simonw/datasette/issues/889#issuecomment-653002499 | https://api.github.com/repos/simonw/datasette/issues/889 | MDEyOklzc3VlQ29tbWVudDY1MzAwMjQ5OQ== | amjith 49260 | 2020-07-02T13:22:13Z | 2020-07-02T13:22:13Z | CONTRIBUTOR | I was able to narrow this down to the fact that lifespan protocol is turned on. I see the workaround you've used here: https://github.com/simonw/datasette-debug-asgi/commit/72d568d32a3159c763ce908c0b269736935c6987 If so, maybe it's time to update some of the asg_wrapper plugins. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
asgi_wrapper plugin hook is crashing at startup 649907676 | |
652990131 | https://github.com/simonw/datasette/issues/889#issuecomment-652990131 | https://api.github.com/repos/simonw/datasette/issues/889 | MDEyOklzc3VlQ29tbWVudDY1Mjk5MDEzMQ== | amjith 49260 | 2020-07-02T12:58:11Z | 2020-07-02T13:00:18Z | CONTRIBUTOR | FWIW, this error does NOT happen in datasette 0.45a4. It only started on 0.45a5 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
asgi_wrapper plugin hook is crashing at startup 649907676 | |
652732460 | https://github.com/simonw/datasette/issues/886#issuecomment-652732460 | https://api.github.com/repos/simonw/datasette/issues/886 | MDEyOklzc3VlQ29tbWVudDY1MjczMjQ2MA== | simonw 9599 | 2020-07-02T01:52:02Z | 2020-07-02T01:52:02Z | OWNER | In investigating this I'm not convinced 500 errors are being correctly raised by errors in canned writable queries. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Reconsider how _actor_X magic parameter deals with missing values 649429772 | |
652731459 | https://github.com/simonw/datasette/issues/886#issuecomment-652731459 | https://api.github.com/repos/simonw/datasette/issues/886 | MDEyOklzc3VlQ29tbWVudDY1MjczMTQ1OQ== | simonw 9599 | 2020-07-02T01:48:08Z | 2020-07-02T01:48:08Z | OWNER | A common error with this (and other) magic parameters is for the database query to result in the following:
This is a pretty crufty error. I'm inclined to say that ANY missing or invalid magic parameter should be treated as a |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Reconsider how _actor_X magic parameter deals with missing values 649429772 | |
652711822 | https://github.com/simonw/datasette/issues/887#issuecomment-652711822 | https://api.github.com/repos/simonw/datasette/issues/887 | MDEyOklzc3VlQ29tbWVudDY1MjcxMTgyMg== | simonw 9599 | 2020-07-02T00:31:33Z | 2020-07-02T00:31:33Z | OWNER | If a canned query has a title defined that will be used instead: https://latest.datasette.io/fixtures/neighborhood_search |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Canned query page should show the name of the canned query 649437530 | |
652711562 | https://github.com/simonw/datasette/issues/887#issuecomment-652711562 | https://api.github.com/repos/simonw/datasette/issues/887 | MDEyOklzc3VlQ29tbWVudDY1MjcxMTU2Mg== | simonw 9599 | 2020-07-02T00:30:43Z | 2020-07-02T00:30:43Z | OWNER | Demo has updated: https://latest.datasette.io/fixtures/magic_parameters |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Canned query page should show the name of the canned query 649437530 | |
652710178 | https://github.com/simonw/datasette/pull/883#issuecomment-652710178 | https://api.github.com/repos/simonw/datasette/issues/883 | MDEyOklzc3VlQ29tbWVudDY1MjcxMDE3OA== | simonw 9599 | 2020-07-02T00:25:44Z | 2020-07-02T00:25:44Z | OWNER | This is a great idea. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Skip counting hidden tables 648749062 | |
652709199 | https://github.com/simonw/datasette/issues/887#issuecomment-652709199 | https://api.github.com/repos/simonw/datasette/issues/887 | MDEyOklzc3VlQ29tbWVudDY1MjcwOTE5OQ== | simonw 9599 | 2020-07-02T00:21:54Z | 2020-07-02T00:21:54Z | OWNER | Example in the live demo: https://latest.datasette.io/fixtures/magic_parameters |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Canned query page should show the name of the canned query 649437530 | |
652681996 | https://github.com/simonw/datasette/issues/885#issuecomment-652681996 | https://api.github.com/repos/simonw/datasette/issues/885 | MDEyOklzc3VlQ29tbWVudDY1MjY4MTk5Ng== | simonw 9599 | 2020-07-01T22:44:47Z | 2020-07-01T22:44:47Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Blog entry about the release 649373451 | ||
652663177 | https://github.com/simonw/datasette/issues/882#issuecomment-652663177 | https://api.github.com/repos/simonw/datasette/issues/882 | MDEyOklzc3VlQ29tbWVudDY1MjY2MzE3Nw== | simonw 9599 | 2020-07-01T21:48:08Z | 2020-07-01T21:48:08Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Release notes for 0.45 648673556 | ||
652646487 | https://github.com/simonw/datasette/issues/880#issuecomment-652646487 | https://api.github.com/repos/simonw/datasette/issues/880 | MDEyOklzc3VlQ29tbWVudDY1MjY0NjQ4Nw== | simonw 9599 | 2020-07-01T21:05:48Z | 2020-07-01T21:05:48Z | OWNER | I've been testing the WIP using this in the console:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
POST to /db/canned-query that returns JSON should be supported (for API clients) 648637666 | |
652604569 | https://github.com/simonw/datasette/issues/882#issuecomment-652604569 | https://api.github.com/repos/simonw/datasette/issues/882 | MDEyOklzc3VlQ29tbWVudDY1MjYwNDU2OQ== | simonw 9599 | 2020-07-01T19:27:17Z | 2020-07-01T19:27:17Z | OWNER | Don't forget to update the news in the README. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Release notes for 0.45 648673556 | |
652597975 | https://github.com/simonw/datasette/issues/877#issuecomment-652597975 | https://api.github.com/repos/simonw/datasette/issues/877 | MDEyOklzc3VlQ29tbWVudDY1MjU5Nzk3NQ== | simonw 9599 | 2020-07-01T19:12:15Z | 2020-07-01T19:12:15Z | OWNER | The latest release of https://github.com/simonw/datasette-auth-tokens (0.2) now supports SQL configuration of tokens. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Consider dropping explicit CSRF protection entirely? 648421105 | |
652520496 | https://github.com/simonw/datasette/issues/877#issuecomment-652520496 | https://api.github.com/repos/simonw/datasette/issues/877 | MDEyOklzc3VlQ29tbWVudDY1MjUyMDQ5Ng== | simonw 9599 | 2020-07-01T16:26:52Z | 2020-07-01T16:26:52Z | OWNER | Tokens get verified by plugins. So far there's only one: https://github.com/simonw/datasette-auth-tokens - which has you hard-coding plugins in a configuration file. I have a issue there to add support for database-backed tokens too: https://github.com/simonw/datasette-auth-tokens/issues/1 |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Consider dropping explicit CSRF protection entirely? 648421105 | |
652394742 | https://github.com/simonw/datasette/pull/883#issuecomment-652394742 | https://api.github.com/repos/simonw/datasette/issues/883 | MDEyOklzc3VlQ29tbWVudDY1MjM5NDc0Mg== | abdusco 3243482 | 2020-07-01T12:41:13Z | 2020-07-01T12:41:13Z | CONTRIBUTOR | Well tests need to be updated. I need to get tests working on Windows. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Skip counting hidden tables 648749062 | |
652311990 | https://github.com/simonw/datasette/pull/883#issuecomment-652311990 | https://api.github.com/repos/simonw/datasette/issues/883 | MDEyOklzc3VlQ29tbWVudDY1MjMxMTk5MA== | codecov[bot] 22429695 | 2020-07-01T09:40:40Z | 2020-07-01T09:40:40Z | NONE | Codecov Report
```diff @@ Coverage Diff @@ master #883 +/-=======================================
Coverage 83.42% 83.42% Continue to review full report at Codecov.
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Skip counting hidden tables 648749062 | |
652297139 | https://github.com/simonw/datasette/pull/883#issuecomment-652297139 | https://api.github.com/repos/simonw/datasette/issues/883 | MDEyOklzc3VlQ29tbWVudDY1MjI5NzEzOQ== | abdusco 3243482 | 2020-07-01T09:11:29Z | 2020-07-01T09:11:29Z | CONTRIBUTOR | Turns out we should include hidden tables in the result dict, or we're breaking tests. I've committed a refactor https://github.com/simonw/datasette/pull/883/commits/4f06e1bf6fbe4b73be770b87f610bf7c0e6e3ea7 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Skip counting hidden tables 648749062 | |
652255960 | https://github.com/simonw/datasette/issues/877#issuecomment-652255960 | https://api.github.com/repos/simonw/datasette/issues/877 | MDEyOklzc3VlQ29tbWVudDY1MjI1NTk2MA== | abdusco 3243482 | 2020-07-01T07:52:25Z | 2020-07-01T08:10:00Z | CONTRIBUTOR | I am calling the API from another origin, so injecting CSRF token into templates wouldn't work. EDIT: I'll try the new version, it sounds promising |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Consider dropping explicit CSRF protection entirely? 648421105 | |
652261382 | https://github.com/simonw/datasette/issues/877#issuecomment-652261382 | https://api.github.com/repos/simonw/datasette/issues/877 | MDEyOklzc3VlQ29tbWVudDY1MjI2MTM4Mg== | abdusco 3243482 | 2020-07-01T08:03:17Z | 2020-07-01T08:03:23Z | CONTRIBUTOR | Bearer tokens sound interesting. Where do tokens come from? An auth provider of my choosing? How do they get verified? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Consider dropping explicit CSRF protection entirely? 648421105 | |
652182990 | https://github.com/simonw/datasette/issues/877#issuecomment-652182990 | https://api.github.com/repos/simonw/datasette/issues/877 | MDEyOklzc3VlQ29tbWVudDY1MjE4Mjk5MA== | simonw 9599 | 2020-07-01T04:29:38Z | 2020-07-01T04:42:59Z | OWNER | Have you tried the method described here? https://datasette.readthedocs.io/en/latest/internals.html#csrf-protection - I'm happy to bulk out that section of the documentation if that doesn't help solve your problem. I just closed #835 which should make CSRF protection easier to work with - it won't interfere with requests without cookies or requests with You can try out |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Consider dropping explicit CSRF protection entirely? 648421105 | |
652166115 | https://github.com/simonw/datasette/issues/877#issuecomment-652166115 | https://api.github.com/repos/simonw/datasette/issues/877 | MDEyOklzc3VlQ29tbWVudDY1MjE2NjExNQ== | abdusco 3243482 | 2020-07-01T03:28:07Z | 2020-07-01T03:28:07Z | CONTRIBUTOR | Does this mean custom routes get to expose endpoints accepting POST requests? I've tried earlier to add some POST endpoints, but requests were being rejected by Datasette due to CSRF |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Consider dropping explicit CSRF protection entirely? 648421105 | |
652165709 | https://github.com/simonw/datasette/issues/812#issuecomment-652165709 | https://api.github.com/repos/simonw/datasette/issues/812 | MDEyOklzc3VlQ29tbWVudDY1MjE2NTcwOQ== | simonw 9599 | 2020-07-01T03:26:35Z | 2020-07-01T03:26:35Z | OWNER | This case may not be covered without extra work: https://github.com/simonw/datasette/blob/3ec5b1abf6afa2d22a3378092809a1a8c0249d26/datasette/views/database.py#L122-L123 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Ability to customize what happens when a view permission fails 634112607 | |
652163450 | https://github.com/simonw/datasette/issues/812#issuecomment-652163450 | https://api.github.com/repos/simonw/datasette/issues/812 | MDEyOklzc3VlQ29tbWVudDY1MjE2MzQ1MA== | simonw 9599 | 2020-07-01T03:18:51Z | 2020-07-01T03:20:28Z | OWNER | This can be a plugin hook:
Maybe the hook can instead use the I'm going to leave |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Ability to customize what happens when a view permission fails 634112607 | |
652162722 | https://github.com/simonw/datasette/issues/880#issuecomment-652162722 | https://api.github.com/repos/simonw/datasette/issues/880 | MDEyOklzc3VlQ29tbWVudDY1MjE2MjcyMg== | simonw 9599 | 2020-07-01T03:16:07Z | 2020-07-01T03:16:07Z | OWNER | The response from this will never be a 302 - it will always be a 200 if the response worked or a 400 for bad parameters or a 500 for errors. The body returned will always be in JSON format. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
POST to /db/canned-query that returns JSON should be supported (for API clients) 648637666 | |
652160909 | https://github.com/simonw/datasette/issues/859#issuecomment-652160909 | https://api.github.com/repos/simonw/datasette/issues/859 | MDEyOklzc3VlQ29tbWVudDY1MjE2MDkwOQ== | abdusco 3243482 | 2020-07-01T03:09:32Z | 2020-07-01T03:10:21Z | CONTRIBUTOR | I've just realized Datasette tries to count hidden tables too. There are 5 visible tables, 25 hidden tables, which I haven't realize earlier to consider their effect. I've turned off counting for hidden tables to see if it has any effect. What's the point of counting FTS tables? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Database page loads too slowly with many large tables (due to table counts) 642572841 | |
652159398 | https://github.com/simonw/datasette/issues/835#issuecomment-652159398 | https://api.github.com/repos/simonw/datasette/issues/835 | MDEyOklzc3VlQ29tbWVudDY1MjE1OTM5OA== | simonw 9599 | 2020-07-01T03:03:51Z | 2020-07-01T03:03:51Z | OWNER | I'm going to add some tests for this. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Mechanism for skipping CSRF checks on API posts 637363686 | |
652106227 | https://github.com/simonw/datasette/issues/876#issuecomment-652106227 | https://api.github.com/repos/simonw/datasette/issues/876 | MDEyOklzc3VlQ29tbWVudDY1MjEwNjIyNw== | simonw 9599 | 2020-06-30T23:49:55Z | 2020-06-30T23:50:04Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Add log out link to the pattern portfolio 647879783 | ||
652105722 | https://github.com/simonw/datasette/issues/879#issuecomment-652105722 | https://api.github.com/repos/simonw/datasette/issues/879 | MDEyOklzc3VlQ29tbWVudDY1MjEwNTcyMg== | simonw 9599 | 2020-06-30T23:48:06Z | 2020-06-30T23:48:06Z | OWNER | Updated documentation: https://datasette.readthedocs.io/en/latest/pages.html |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Database page documentation still talks about hashes in URLs 648569227 | |
652103895 | https://github.com/simonw/datasette/issues/832#issuecomment-652103895 | https://api.github.com/repos/simonw/datasette/issues/832 | MDEyOklzc3VlQ29tbWVudDY1MjEwMzg5NQ== | simonw 9599 | 2020-06-30T23:41:22Z | 2020-06-30T23:41:22Z | OWNER | I don't think this needs any additional documentation - the new behaviour matches how the permissions are documented here: https://datasette.readthedocs.io/en/0.44/authentication.html#built-in-permissions |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Having view-table permission but NOT view-database should still grant access to /db/table 636722501 | |
651999516 | https://github.com/simonw/datasette/issues/832#issuecomment-651999516 | https://api.github.com/repos/simonw/datasette/issues/832 | MDEyOklzc3VlQ29tbWVudDY1MTk5OTUxNg== | simonw 9599 | 2020-06-30T19:33:49Z | 2020-06-30T21:34:59Z | OWNER | Tests needed for this:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Having view-table permission but NOT view-database should still grant access to /db/table 636722501 | |
651995453 | https://github.com/simonw/datasette/issues/832#issuecomment-651995453 | https://api.github.com/repos/simonw/datasette/issues/832 | MDEyOklzc3VlQ29tbWVudDY1MTk5NTQ1Mw== | simonw 9599 | 2020-06-30T19:25:13Z | 2020-06-30T19:25:26Z | OWNER | I'm going to put the new |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Having view-table permission but NOT view-database should still grant access to /db/table 636722501 | |
651994978 | https://github.com/simonw/datasette/issues/832#issuecomment-651994978 | https://api.github.com/repos/simonw/datasette/issues/832 | MDEyOklzc3VlQ29tbWVudDY1MTk5NDk3OA== | simonw 9599 | 2020-06-30T19:24:12Z | 2020-06-30T19:24:12Z | OWNER | Hah... but check_permission And on BaseView: |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Having view-table permission but NOT view-database should still grant access to /db/table 636722501 | |
651993977 | https://github.com/simonw/datasette/issues/832#issuecomment-651993977 | https://api.github.com/repos/simonw/datasette/issues/832 | MDEyOklzc3VlQ29tbWVudDY1MTk5Mzk3Nw== | simonw 9599 | 2020-06-30T19:22:06Z | 2020-06-30T19:22:06Z | OWNER |
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Having view-table permission but NOT view-database should still grant access to /db/table 636722501 | |
651993537 | https://github.com/simonw/datasette/issues/832#issuecomment-651993537 | https://api.github.com/repos/simonw/datasette/issues/832 | MDEyOklzc3VlQ29tbWVudDY1MTk5MzUzNw== | simonw 9599 | 2020-06-30T19:21:15Z | 2020-06-30T19:21:15Z | OWNER | I could rename This is a breaking change but we're pre-1.0 so I think that's OK. I could even set up a temporary |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Having view-table permission but NOT view-database should still grant access to /db/table 636722501 | |
651992737 | https://github.com/simonw/datasette/issues/832#issuecomment-651992737 | https://api.github.com/repos/simonw/datasette/issues/832 | MDEyOklzc3VlQ29tbWVudDY1MTk5MjczNw== | simonw 9599 | 2020-06-30T19:19:33Z | 2020-06-30T19:20:02Z | OWNER | I already have this method on Datasette:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Having view-table permission but NOT view-database should still grant access to /db/table 636722501 | |
651984989 | https://github.com/simonw/datasette/issues/877#issuecomment-651984989 | https://api.github.com/repos/simonw/datasette/issues/877 | MDEyOklzc3VlQ29tbWVudDY1MTk4NDk4OQ== | simonw 9599 | 2020-06-30T19:03:25Z | 2020-06-30T19:03:25Z | OWNER | Relevant: #835 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Consider dropping explicit CSRF protection entirely? 648421105 | |
651984355 | https://github.com/simonw/datasette/issues/877#issuecomment-651984355 | https://api.github.com/repos/simonw/datasette/issues/877 | MDEyOklzc3VlQ29tbWVudDY1MTk4NDM1NQ== | simonw 9599 | 2020-06-30T19:02:15Z | 2020-06-30T19:02:15Z | OWNER |
Sounds like regular CSRF protection to me. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Consider dropping explicit CSRF protection entirely? 648421105 | |
651302221 | https://github.com/simonw/datasette/issues/805#issuecomment-651302221 | https://api.github.com/repos/simonw/datasette/issues/805 | MDEyOklzc3VlQ29tbWVudDY1MTMwMjIyMQ== | simonw 9599 | 2020-06-29T19:02:45Z | 2020-06-29T19:05:26Z | OWNER | No I prefer the idea that logged out users can still perform some writes, in a not-likely-to-attract-abuse way. So a root-user-can-configure-polls, logged-out-users-can-vote-in-them demo would be good. Or... crazy idea: a collaborative drawing program? A grid of cells of emoji, anyone can add an emoji to a cell. Would involve a bit of JavaScript. I could use https://github.com/joeattardi/emoji-button for this. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Writable canned queries live demo on Glitch 632724154 | |
651301202 | https://github.com/simonw/datasette/issues/805#issuecomment-651301202 | https://api.github.com/repos/simonw/datasette/issues/805 | MDEyOklzc3VlQ29tbWVudDY1MTMwMTIwMg== | simonw 9599 | 2020-06-29T19:00:37Z | 2020-06-29T19:00:37Z | OWNER | How about a blog? Pre-configured canned queries that are only available to |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Writable canned queries live demo on Glitch 632724154 | |
651293559 | https://github.com/simonw/datasette/issues/875#issuecomment-651293559 | https://api.github.com/repos/simonw/datasette/issues/875 | MDEyOklzc3VlQ29tbWVudDY1MTI5MzU1OQ== | simonw 9599 | 2020-06-29T18:43:50Z | 2020-06-29T18:43:50Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
"Logged in as: XXX - logout" navigation item 647103735 | ||
651203178 | https://github.com/simonw/datasette/issues/873#issuecomment-651203178 | https://api.github.com/repos/simonw/datasette/issues/873 | MDEyOklzc3VlQ29tbWVudDY1MTIwMzE3OA== | simonw 9599 | 2020-06-29T15:44:38Z | 2020-06-29T15:44:54Z | OWNER | I'm having real trouble figuring out how to gain access to the port that was used to start the server. I'm treating this as a very low priority - it only affects the exact |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
"datasette -p 0 --root" gives the wrong URL 647095487 | |
651193594 | https://github.com/simonw/datasette/issues/873#issuecomment-651193594 | https://api.github.com/repos/simonw/datasette/issues/873 | MDEyOklzc3VlQ29tbWVudDY1MTE5MzU5NA== | simonw 9599 | 2020-06-29T15:27:46Z | 2020-06-29T15:27:46Z | OWNER | Uninstalling |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
"datasette -p 0 --root" gives the wrong URL 647095487 | |
651193131 | https://github.com/simonw/datasette/issues/873#issuecomment-651193131 | https://api.github.com/repos/simonw/datasette/issues/873 | MDEyOklzc3VlQ29tbWVudDY1MTE5MzEzMQ== | simonw 9599 | 2020-06-29T15:27:00Z | 2020-06-29T15:27:00Z | OWNER | Aha! Yes it's not being called, and the reason is this: https://github.com/encode/starlette/issues/486 Short version: by default an exception raised during that phase is silently swallowed! You can avoid the swallowing by adding When I did that here:
The server failed to start with this error:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
"datasette -p 0 --root" gives the wrong URL 647095487 | |
650910137 | https://github.com/simonw/datasette/issues/873#issuecomment-650910137 | https://api.github.com/repos/simonw/datasette/issues/873 | MDEyOklzc3VlQ29tbWVudDY1MDkxMDEzNw== | simonw 9599 | 2020-06-29T05:16:32Z | 2020-06-29T05:16:32Z | OWNER | I'm not convinced that function is ever actually being called - I added a |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
"datasette -p 0 --root" gives the wrong URL 647095487 | |
650909476 | https://github.com/simonw/datasette/issues/873#issuecomment-650909476 | https://api.github.com/repos/simonw/datasette/issues/873 | MDEyOklzc3VlQ29tbWVudDY1MDkwOTQ3Ng== | simonw 9599 | 2020-06-29T05:14:08Z | 2020-06-29T05:14:08Z | OWNER | I already have a It runs this function: https://github.com/simonw/datasette/blob/35aee82c60b2c9a0185b934db5528c8bd11830f2/datasette/app.py#L890-L894 Could that startup function also output the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
"datasette -p 0 --root" gives the wrong URL 647095487 | |
650909136 | https://github.com/simonw/datasette/issues/873#issuecomment-650909136 | https://api.github.com/repos/simonw/datasette/issues/873 | MDEyOklzc3VlQ29tbWVudDY1MDkwOTEzNg== | simonw 9599 | 2020-06-29T05:12:58Z | 2020-06-29T05:12:58Z | OWNER | On startup Datasette currently outputs:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
"datasette -p 0 --root" gives the wrong URL 647095487 | |
650908854 | https://github.com/simonw/datasette/issues/873#issuecomment-650908854 | https://api.github.com/repos/simonw/datasette/issues/873 | MDEyOklzc3VlQ29tbWVudDY1MDkwODg1NA== | simonw 9599 | 2020-06-29T05:12:04Z | 2020-06-29T05:12:04Z | OWNER | Can I detect the port the server is running on from within the regular Datasette ASGI code? If so I could use that ability and maybe output the magic |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
"datasette -p 0 --root" gives the wrong URL 647095487 | |
650908534 | https://github.com/simonw/datasette/issues/873#issuecomment-650908534 | https://api.github.com/repos/simonw/datasette/issues/873 | MDEyOklzc3VlQ29tbWVudDY1MDkwODUzNA== | simonw 9599 | 2020-06-29T05:11:06Z | 2020-06-29T05:11:06Z | OWNER | Uvicorn's lifespan stuff isn't easy to figure out, but this test suite holds some clues: https://github.com/encode/uvicorn/blob/master/tests/test_lifespan.py |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
"datasette -p 0 --root" gives the wrong URL 647095487 | |
650907323 | https://github.com/simonw/datasette/issues/873#issuecomment-650907323 | https://api.github.com/repos/simonw/datasette/issues/873 | MDEyOklzc3VlQ29tbWVudDY1MDkwNzMyMw== | simonw 9599 | 2020-06-29T05:07:16Z | 2020-06-29T05:07:16Z | OWNER | This line is interesting: is this a hook I can attach to somehow?
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
"datasette -p 0 --root" gives the wrong URL 647095487 | |
650906533 | https://github.com/simonw/datasette/issues/873#issuecomment-650906533 | https://api.github.com/repos/simonw/datasette/issues/873 | MDEyOklzc3VlQ29tbWVudDY1MDkwNjUzMw== | simonw 9599 | 2020-06-29T05:04:44Z | 2020-06-29T05:04:44Z | OWNER | The challenge is... can we run our own custom code after that line has executed that has access to |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
"datasette -p 0 --root" gives the wrong URL 647095487 | |
650906318 | https://github.com/simonw/datasette/issues/873#issuecomment-650906318 | https://api.github.com/repos/simonw/datasette/issues/873 | MDEyOklzc3VlQ29tbWVudDY1MDkwNjMxOA== | simonw 9599 | 2020-06-29T05:04:04Z | 2020-06-29T05:04:12Z | OWNER | Within uvicorn it does this:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
"datasette -p 0 --root" gives the wrong URL 647095487 | |
650905399 | https://github.com/simonw/datasette/issues/873#issuecomment-650905399 | https://api.github.com/repos/simonw/datasette/issues/873 | MDEyOklzc3VlQ29tbWVudDY1MDkwNTM5OQ== | simonw 9599 | 2020-06-29T05:01:03Z | 2020-06-29T05:01:03Z | OWNER | This is a bit tricky to fix. This change to uvicorn is relevant: https://github.com/encode/uvicorn/commit/a75fe1381f6b1f78901691c71894f3cf487b5d30 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
"datasette -p 0 --root" gives the wrong URL 647095487 | |
650899265 | https://github.com/simonw/datasette/issues/875#issuecomment-650899265 | https://api.github.com/repos/simonw/datasette/issues/875 | MDEyOklzc3VlQ29tbWVudDY1MDg5OTI2NQ== | simonw 9599 | 2020-06-29T04:34:32Z | 2020-06-29T04:34:32Z | OWNER | From https://github.com/simonw/datasette/issues/840#issuecomment-643454625
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
"Logged in as: XXX - logout" navigation item 647103735 | |
650898808 | https://github.com/simonw/datasette/issues/875#issuecomment-650898808 | https://api.github.com/repos/simonw/datasette/issues/875 | MDEyOklzc3VlQ29tbWVudDY1MDg5ODgwOA== | simonw 9599 | 2020-06-29T04:32:31Z | 2020-06-29T04:33:30Z | OWNER | I could borrow the implementation for this from {% block extra_head %} <style type="text/css"> .hd .logout { float: right; text-align: right; padding-left: 1em; } </style>{% endblock %} {% block nav %} {{ super() }} {% if auth and auth.username %} {{ auth.username }} · Log out {% endif %} {% endblock %} ``` |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
"Logged in as: XXX - logout" navigation item 647103735 | |
650895874 | https://github.com/simonw/datasette/issues/840#issuecomment-650895874 | https://api.github.com/repos/simonw/datasette/issues/840 | MDEyOklzc3VlQ29tbWVudDY1MDg5NTg3NA== | simonw 9599 | 2020-06-29T04:18:59Z | 2020-06-29T04:19:11Z | OWNER | Now just need the "Logged in as: XXX <logout>" navigation item. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Log out mechanism for clearing ds_actor cookie 637966833 | |
650891502 | https://github.com/simonw/datasette/issues/840#issuecomment-650891502 | https://api.github.com/repos/simonw/datasette/issues/840 | MDEyOklzc3VlQ29tbWVudDY1MDg5MTUwMg== | simonw 9599 | 2020-06-29T03:58:08Z | 2020-06-29T03:58:08Z | OWNER | Step one: a "logout" page at |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Log out mechanism for clearing ds_actor cookie 637966833 | |
650891257 | https://github.com/simonw/datasette/issues/805#issuecomment-650891257 | https://api.github.com/repos/simonw/datasette/issues/805 | MDEyOklzc3VlQ29tbWVudDY1MDg5MTI1Nw== | simonw 9599 | 2020-06-29T03:56:48Z | 2020-06-29T03:56:48Z | OWNER | Using |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Writable canned queries live demo on Glitch 632724154 | |
650847013 | https://github.com/simonw/datasette/issues/864#issuecomment-650847013 | https://api.github.com/repos/simonw/datasette/issues/864 | MDEyOklzc3VlQ29tbWVudDY1MDg0NzAxMw== | simonw 9599 | 2020-06-29T00:41:55Z | 2020-06-29T00:41:55Z | OWNER | To test this I'll need a plugin test that renders a custom template. Here's an example I can imitate: https://github.com/simonw/datasette/blob/7ac4936cec87f5a591e5d2680f0acefc3d35a705/tests/test_plugins.py#L588-L596 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
datasette.add_message() doesn't work inside plugins 644309017 | |
650846625 | https://github.com/simonw/datasette/issues/864#issuecomment-650846625 | https://api.github.com/repos/simonw/datasette/issues/864 | MDEyOklzc3VlQ29tbWVudDY1MDg0NjYyNQ== | simonw 9599 | 2020-06-29T00:39:47Z | 2020-06-29T00:39:47Z | OWNER | I think the fix is to move the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
datasette.add_message() doesn't work inside plugins 644309017 | |
650846473 | https://github.com/simonw/datasette/issues/864#issuecomment-650846473 | https://api.github.com/repos/simonw/datasette/issues/864 | MDEyOklzc3VlQ29tbWVudDY1MDg0NjQ3Mw== | simonw 9599 | 2020-06-29T00:39:04Z | 2020-06-29T00:39:04Z | OWNER | Re-opening: plugins may get to set messages but they don't display them, even if they render a template that extends |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
datasette.add_message() doesn't work inside plugins 644309017 | |
650842514 | https://github.com/simonw/datasette/issues/864#issuecomment-650842514 | https://api.github.com/repos/simonw/datasette/issues/864 | MDEyOklzc3VlQ29tbWVudDY1MDg0MjUxNA== | simonw 9599 | 2020-06-29T00:12:59Z | 2020-06-29T00:12:59Z | OWNER |
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
datasette.add_message() doesn't work inside plugins 644309017 | |
650842381 | https://github.com/simonw/datasette/issues/870#issuecomment-650842381 | https://api.github.com/repos/simonw/datasette/issues/870 | MDEyOklzc3VlQ29tbWVudDY1MDg0MjM4MQ== | simonw 9599 | 2020-06-29T00:12:07Z | 2020-06-29T00:12:07Z | OWNER | I've made enough progress on this to be able to solve the messages issue in #864. I may still complete this overall goal (registering internal views with |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Refactor default views to use register_routes 646737558 | |
650838972 | https://github.com/simonw/datasette/issues/870#issuecomment-650838972 | https://api.github.com/repos/simonw/datasette/issues/870 | MDEyOklzc3VlQ29tbWVudDY1MDgzODk3Mg== | simonw 9599 | 2020-06-28T23:46:40Z | 2020-06-28T23:46:40Z | OWNER | I'm going to create the single |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Refactor default views to use register_routes 646737558 | |
650838691 | https://github.com/simonw/datasette/issues/870#issuecomment-650838691 | https://api.github.com/repos/simonw/datasette/issues/870 | MDEyOklzc3VlQ29tbWVudDY1MDgzODY5MQ== | simonw 9599 | 2020-06-28T23:44:12Z | 2020-06-28T23:44:25Z | OWNER | This code is interesting: I want to change the signature of that The problem is the scope modification: I have code that modifies the scope, but how should that impact a shared |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Refactor default views to use register_routes 646737558 | |
650834666 | https://github.com/simonw/datasette/issues/870#issuecomment-650834666 | https://api.github.com/repos/simonw/datasette/issues/870 | MDEyOklzc3VlQ29tbWVudDY1MDgzNDY2Ng== | simonw 9599 | 2020-06-28T23:07:19Z | 2020-06-28T23:07:19Z | OWNER | So now the problem is simpler: I need to get |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Refactor default views to use register_routes 646737558 | |
650834251 | https://github.com/simonw/datasette/issues/870#issuecomment-650834251 | https://api.github.com/repos/simonw/datasette/issues/870 | MDEyOklzc3VlQ29tbWVudDY1MDgzNDI1MQ== | simonw 9599 | 2020-06-28T23:03:28Z | 2020-06-28T23:03:28Z | OWNER | I'm going to ditch that |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Refactor default views to use register_routes 646737558 | |
650820068 | https://github.com/simonw/datasette/issues/870#issuecomment-650820068 | https://api.github.com/repos/simonw/datasette/issues/870 | MDEyOklzc3VlQ29tbWVudDY1MDgyMDA2OA== | simonw 9599 | 2020-06-28T20:52:09Z | 2020-06-28T20:53:00Z | OWNER | Maybe I could add a Or I could teach the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Refactor default views to use register_routes 646737558 | |
650819895 | https://github.com/simonw/datasette/issues/847#issuecomment-650819895 | https://api.github.com/repos/simonw/datasette/issues/847 | MDEyOklzc3VlQ29tbWVudDY1MDgxOTg5NQ== | simonw 9599 | 2020-06-28T20:50:21Z | 2020-06-28T20:50:21Z | OWNER | I'm happy enough with https://codecov.io/gh/simonw/datasette that I'm not going to spend any more time on this. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Take advantage of .coverage being a SQLite database 638259643 | |
650818309 | https://github.com/simonw/datasette/issues/870#issuecomment-650818309 | https://api.github.com/repos/simonw/datasette/issues/870 | MDEyOklzc3VlQ29tbWVudDY1MDgxODMwOQ== | simonw 9599 | 2020-06-28T20:36:28Z | 2020-06-28T20:36:52Z | OWNER | Since I could also rename it to just |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Refactor default views to use register_routes 646737558 | |
650818086 | https://github.com/simonw/datasette/issues/870#issuecomment-650818086 | https://api.github.com/repos/simonw/datasette/issues/870 | MDEyOklzc3VlQ29tbWVudDY1MDgxODA4Ng== | simonw 9599 | 2020-06-28T20:34:33Z | 2020-06-28T20:34:33Z | OWNER | The key to all of this may be the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Refactor default views to use register_routes 646737558 | |
650815278 | https://github.com/simonw/datasette/issues/870#issuecomment-650815278 | https://api.github.com/repos/simonw/datasette/issues/870 | MDEyOklzc3VlQ29tbWVudDY1MDgxNTI3OA== | simonw 9599 | 2020-06-28T20:09:07Z | 2020-06-28T20:11:21Z | OWNER | There's a lot of complex logic in the That view subclasses |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Refactor default views to use register_routes 646737558 | |
650812444 | https://github.com/simonw/datasette/issues/871#issuecomment-650812444 | https://api.github.com/repos/simonw/datasette/issues/871 | MDEyOklzc3VlQ29tbWVudDY1MDgxMjQ0NA== | simonw 9599 | 2020-06-28T19:43:27Z | 2020-06-28T19:43:27Z | OWNER | Currently:
I'm going to rename them to:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Rename the _timestamp magic parameters to _now 646840273 | |
650811919 | https://github.com/simonw/datasette/issues/834#issuecomment-650811919 | https://api.github.com/repos/simonw/datasette/issues/834 | MDEyOklzc3VlQ29tbWVudDY1MDgxMTkxOQ== | simonw 9599 | 2020-06-28T19:38:50Z | 2020-06-28T19:38:50Z | OWNER | I have two plugins in progress that use this hook now:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
startup() plugin hook 637342551 | |
650784162 | https://github.com/simonw/datasette/issues/805#issuecomment-650784162 | https://api.github.com/repos/simonw/datasette/issues/805 | MDEyOklzc3VlQ29tbWVudDY1MDc4NDE2Mg== | simonw 9599 | 2020-06-28T15:48:32Z | 2020-06-28T15:48:32Z | OWNER | https://github.com/simonw/datasette-glitch is my new plugin that outputs the root login link on Glitch when the server starts. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Writable canned queries live demo on Glitch 632724154 | |
643657067 | https://github.com/simonw/datasette/issues/834#issuecomment-643657067 | https://api.github.com/repos/simonw/datasette/issues/834 | MDEyOklzc3VlQ29tbWVudDY0MzY1NzA2Nw== | simonw 9599 | 2020-06-13T17:59:42Z | 2020-06-28T04:01:52Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
startup() plugin hook 637342551 | ||
650684635 | https://github.com/simonw/datasette/issues/842#issuecomment-650684635 | https://api.github.com/repos/simonw/datasette/issues/842 | MDEyOklzc3VlQ29tbWVudDY1MDY4NDYzNQ== | simonw 9599 | 2020-06-28T03:30:31Z | 2020-06-28T03:30:31Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Magic parameters for canned queries 638212085 | ||
650681496 | https://github.com/simonw/datasette/issues/805#issuecomment-650681496 | https://api.github.com/repos/simonw/datasette/issues/805 | MDEyOklzc3VlQ29tbWVudDY1MDY4MTQ5Ng== | simonw 9599 | 2020-06-28T03:11:51Z | 2020-06-28T03:11:51Z | OWNER | I can use magic parameters from #842 in this. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Writable canned queries live demo on Glitch 632724154 | |
650679100 | https://github.com/simonw/datasette/issues/842#issuecomment-650679100 | https://api.github.com/repos/simonw/datasette/issues/842 | MDEyOklzc3VlQ29tbWVudDY1MDY3OTEwMA== | simonw 9599 | 2020-06-28T03:00:44Z | 2020-06-28T03:00:44Z | OWNER | I'm going to add some canned queries to the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Magic parameters for canned queries 638212085 | |
650678951 | https://github.com/simonw/datasette/issues/842#issuecomment-650678951 | https://api.github.com/repos/simonw/datasette/issues/842 | MDEyOklzc3VlQ29tbWVudDY1MDY3ODk1MQ== | simonw 9599 | 2020-06-28T02:59:52Z | 2020-06-28T02:59:52Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Magic parameters for canned queries 638212085 | ||
650600176 | https://github.com/simonw/datasette/pull/869#issuecomment-650600176 | https://api.github.com/repos/simonw/datasette/issues/869 | MDEyOklzc3VlQ29tbWVudDY1MDYwMDE3Ng== | codecov[bot] 22429695 | 2020-06-27T18:41:31Z | 2020-06-28T02:54:21Z | NONE | Codecov Report
```diff @@ Coverage Diff @@ master #869 +/-==========================================
+ Coverage 82.99% 83.23% +0.23% | Impacted Files | Coverage Δ | |
|---|---|---|
| datasette/plugins.py | Continue to review full report at Codecov.
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Magic parameters for canned queries 646734280 | |
650648434 | https://github.com/simonw/datasette/issues/842#issuecomment-650648434 | https://api.github.com/repos/simonw/datasette/issues/842 | MDEyOklzc3VlQ29tbWVudDY1MDY0ODQzNA== | simonw 9599 | 2020-06-27T23:27:35Z | 2020-06-27T23:37:38Z | OWNER | I'm going to rename |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Magic parameters for canned queries 638212085 | |
650600606 | https://github.com/simonw/datasette/pull/868#issuecomment-650600606 | https://api.github.com/repos/simonw/datasette/issues/868 | MDEyOklzc3VlQ29tbWVudDY1MDYwMDYwNg== | simonw 9599 | 2020-06-27T18:44:28Z | 2020-06-27T18:44:28Z | OWNER | This is really exciting! Thanks so much for looking into this. I'm interested in moving CI for this repo over to GitHub Actions, so I'd be fine with you getting this to work as an Action rather than through Travis. If you can get it working in Travis though I'll happily land that and figure out how to convert that to GitHub Actions later on. |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
initial windows ci setup 646448486 | |
650598710 | https://github.com/simonw/datasette/issues/835#issuecomment-650598710 | https://api.github.com/repos/simonw/datasette/issues/835 | MDEyOklzc3VlQ29tbWVudDY1MDU5ODcxMA== | simonw 9599 | 2020-06-27T18:32:22Z | 2020-06-27T18:32:22Z | OWNER | Skipping CSRF on |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Mechanism for skipping CSRF checks on API posts 637363686 | |
650593122 | https://github.com/simonw/datasette/issues/842#issuecomment-650593122 | https://api.github.com/repos/simonw/datasette/issues/842 | MDEyOklzc3VlQ29tbWVudDY1MDU5MzEyMg== | simonw 9599 | 2020-06-27T18:03:02Z | 2020-06-27T18:03:10Z | OWNER |
This is an open security hole in https://github.com/simonw/datasette/commit/94c1315f0030fd58ce46a9294052c5c9d9d181c7 - it's useful for testing, but I need to remove it before I land that branch. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Magic parameters for canned queries 638212085 | |
650458857 | https://github.com/simonw/datasette/issues/842#issuecomment-650458857 | https://api.github.com/repos/simonw/datasette/issues/842 | MDEyOklzc3VlQ29tbWVudDY1MDQ1ODg1Nw== | simonw 9599 | 2020-06-27T00:11:04Z | 2020-06-27T00:11:04Z | OWNER | Security thought: make sure it's not possible to accidentally open up a security hole where an attacker can send a GET request that causes the magic parameter |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Magic parameters for canned queries 638212085 | |
650455793 | https://github.com/simonw/datasette/issues/842#issuecomment-650455793 | https://api.github.com/repos/simonw/datasette/issues/842 | MDEyOklzc3VlQ29tbWVudDY1MDQ1NTc5Mw== | simonw 9599 | 2020-06-26T23:57:30Z | 2020-06-27T00:00:16Z | OWNER | Maybe I should ship a default
I'm going to have |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Magic parameters for canned queries 638212085 | |
650455353 | https://github.com/simonw/datasette/issues/842#issuecomment-650455353 | https://api.github.com/repos/simonw/datasette/issues/842 | MDEyOklzc3VlQ29tbWVudDY1MDQ1NTM1Mw== | simonw 9599 | 2020-06-26T23:55:40Z | 2020-06-26T23:55:40Z | OWNER |
It probably should - but that means it now needs a bunch of extra configuration to tell it which of those headers can be trusted in the current environment. As such I think I'll leave that for a plugin. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Magic parameters for canned queries 638212085 | |
649931714 | https://github.com/simonw/datasette/issues/867#issuecomment-649931714 | https://api.github.com/repos/simonw/datasette/issues/867 | MDEyOklzc3VlQ29tbWVudDY0OTkzMTcxNA== | simonw 9599 | 2020-06-26T03:12:51Z | 2020-06-26T03:12:51Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
register_routes() should support non-async view functions too 645975649 | ||
649014757 | https://github.com/simonw/datasette/issues/842#issuecomment-649014757 | https://api.github.com/repos/simonw/datasette/issues/842 | MDEyOklzc3VlQ29tbWVudDY0OTAxNDc1Nw== | simonw 9599 | 2020-06-24T19:15:46Z | 2020-06-24T19:31:52Z | OWNER | I'm building this documentation-first - here's the documentation so far: https://github.com/simonw/datasette/blob/6fc8bd9c473f4a25e0a076f24c7e5a9b2f353bb8/docs/sql_queries.rst#magic-parameters |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Magic parameters for canned queries 638212085 | |
646271834 | https://github.com/simonw/datasette/issues/842#issuecomment-646271834 | https://api.github.com/repos/simonw/datasette/issues/842 | MDEyOklzc3VlQ29tbWVudDY0NjI3MTgzNA== | simonw 9599 | 2020-06-18T19:49:41Z | 2020-06-24T18:49:22Z | OWNER | But then what kind of magic parameters might plugins want to add? Here's a crazy idea: |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Magic parameters for canned queries 638212085 | |
646270702 | https://github.com/simonw/datasette/issues/842#issuecomment-646270702 | https://api.github.com/repos/simonw/datasette/issues/842 | MDEyOklzc3VlQ29tbWVudDY0NjI3MDcwMg== | simonw 9599 | 2020-06-18T19:47:19Z | 2020-06-24T18:48:48Z | OWNER | Brainstorming more potential magic parameters:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Magic parameters for canned queries 638212085 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [issue] INTEGER REFERENCES [issues]([id]) , [performed_via_github_app] TEXT); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
issue 887